[FLINK-39620] [table-runtime] Add restored cumulative window regression#28530
[FLINK-39620] [table-runtime] Add restored cumulative window regression#28530qiuyanjun888 wants to merge 1 commit into
Conversation
spuru9
left a comment
There was a problem hiding this comment.
Changes look good. One minor nit.
Can you work on making build green.
|
|
||
| testHarness.prepareSnapshotPreBarrier(0L); | ||
| OperatorSubtaskState snapshot = testHarness.snapshot(0L, 0); | ||
| testHarness.close(); |
There was a problem hiding this comment.
nit: (Optional) Unlike all other restore/close tests in this file this one never asserts globalAggsFunction.closeCalled / stateAggsFunction.closeCalled after close().
|
@flinkbot run azure The failed Azure build appears unrelated to this PR. It failed while Maven was resolving the CycloneDX plugin dependency ( |
|
@flinkbot run azure |
|
This PR is focused on table-runtime / window aggregate regression test. @fhueske @lincoln-lil @JingsongLi could you please take a look when you have time and advise whether this approach is acceptable for this area and can move forward? |
What is the purpose of the change
This pull request adds regression coverage for FLINK-39620. It verifies that after restoring a cumulative window aggregate, flushing the global window buffer before receiving another watermark does not re-emit expired cumulative windows.
Brief change log
Verifying this change
This change added tests and can be verified as follows:
./mvnw -pl flink-table/flink-table-runtime -Dtest=SlicingWindowAggOperatorTest#testGlobalEventTimeCumulativeWindowsDoNotRefireExpiredWindowAfterRestore -DskipITs -Drat.skip=true test./mvnw -pl flink-table/flink-table-runtime -Dtest=SlicingWindowAggOperatorTest -DskipITs -Drat.skip=true testDoes this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?
Generated-by: Hermes Agent (OpenAI GPT-5.5)