[FLINK-40003][runtime] Fix IOMetrics not visible to state transition listeners

[cjohnson-confluent]

What is the purpose of the change

ExecutionStateUpdateListeners registered on the ExecutionGraph are notified
inline during Execution.transitionState(). When a listener reads
execution.getIOMetrics() during a terminal state notification, it always
gets null because updateAccumulatorsAndMetrics() is called after
transitionState() in both markFinished() and processFail().

completeCancelling() already has the correct ordering -- metrics are stored
before the state transition. This PR aligns the other two methods.

Brief change log

• Execution.markFinished(): move updateAccumulatorsAndMetrics() before
  transitionState(current, FINISHED)
• Execution.processFail(): move updateAccumulatorsAndMetrics() before
  transitionState(current, FAILED)

Verifying this change

New test testIOMetricsVisibleToListenersDuringStateTransition in
DefaultExecutionGraphDeploymentTest registers an ExecutionStateUpdateListener
and asserts that getIOMetrics() is non-null (and correct) at notification time
for both FINISHED and FAILED transitions.

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): no
• The public API, i.e., is any changed class annotated with @Public(Evolving): no
• The serializers: no
• The runtime per-record code paths (performance sensitive): no
• Anything that affects deployment or recovery: no
• The S3 file system connector: no

Documentation

• Does this pull request introduce a new feature? no

[flinkbot]

CI report:

• d8461ed Azure: FAILURE

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run azure re-run the last Azure build

[spuru9]

Appears to be some issue with missing variables in the CI, can you check and fix those.