[FLINK-40002][table] Fix PushFilterInCalcIntoTableSourceScanRule for metadata filter push-down#28556
Open
jnh5y wants to merge 1 commit into
Open
[FLINK-40002][table] Fix PushFilterInCalcIntoTableSourceScanRule for metadata filter push-down#28556jnh5y wants to merge 1 commit into
jnh5y wants to merge 1 commit into
Conversation
…metadata filter push-down - Mixed physical+metadata predicates now stay as runtime Calc filters instead of being routed through FilterPushDownSpec, which crashed on compiled-plan restore when ProjectPushDownSpec narrowed the row type. - Fix PushFilterInCalcIntoTableSourceScanRule to separate metadata-only predicates from physical predicates, matching PushFilterIntoTableSourceScanRule. - Extract the duplicated classify-push logic into a shared classifyAndPushFilters() method in PushFilterIntoSourceScanRuleBase. - Document the identity contract on applyMetadataFilters Javadoc. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
spuru9
reviewed
Jun 27, 2026
Comment on lines
+416
to
+420
| @Override | ||
| public Result applyFilters(List<ResolvedExpression> filters) { | ||
| acceptedPhysicalFilters.addAll(filters); | ||
| return Result.of(Collections.emptyList(), filters); | ||
| } |
Contributor
There was a problem hiding this comment.
Can be simplified and the initisialisation of array dropped?
Suggested change
| @Override | |
| public Result applyFilters(List<ResolvedExpression> filters) { | |
| acceptedPhysicalFilters.addAll(filters); | |
| return Result.of(Collections.emptyList(), filters); | |
| } | |
| @Override | |
| public Result applyFilters(List<ResolvedExpression> filters) { | |
| return Result.of(Collections.emptyList(), filters); | |
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
instead of being routed through FilterPushDownSpec, which crashed on
compiled-plan restore when ProjectPushDownSpec narrowed the row type.
predicates from physical predicates, matching PushFilterIntoTableSourceScanRule.
classifyAndPushFilters() method in PushFilterIntoSourceScanRuleBase.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): yes (SupportsReadingMetadata— Javadoc only, no interface change)Documentation
Was generative AI tooling used to co-author this PR?