[FLINK-39499][tests] Launch the SeaweedFS S3 test backend via 'weed mini'#28560
Draft
chrislusf wants to merge 1 commit into
Draft
[FLINK-39499][tests] Launch the SeaweedFS S3 test backend via 'weed mini'#28560chrislusf wants to merge 1 commit into
chrislusf wants to merge 1 commit into
Conversation
…ini' 'weed mini' pre-creates the bucket (-bucket) and reports readiness only after every component is up. Both the Java test container and the S3 end-to-end script now rely on that instead of creating the bucket client-side, which drops the startup-503 retry workaround, the explicit 'aws s3 mb' step, and the /healthz poll in favour of mini's readiness banner. Generated-by: Claude Code (claude-opus-4-8)
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Simplify the SeaweedFS-backed S3 test setup. The container is now launched with
weed mini, which pre-creates the bucket (-bucket) and reports readiness only after every component is up. Both the Java test container and the S3 end-to-end script rely on that instead of creating the bucket client-side.Brief change log
SeaweedFsTestContainer: runmini -bucket=<bucket>; wait on mini's readiness log message; drop the client-sidecreateDefaultBucket()and thewithStartupAttempts(3)startup-503 workaround.common_s3_seaweedfs.sh: runmini -bucket=$IT_CASE_S3_BUCKET; wait on the readiness log message instead of/healthz; drop the explicitaws s3 mb.Verifying this change
This change is already covered by existing tests: the SeaweedFS S3 ITCases (e.g.
HAJobRunOnHadoopS3FileSystemITCase,S5CmdOnSeaweedFsITCase) and the S3 end-to-end tests, which exercise the modified container and script setup.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (claude-opus-4-8)