[GLUTEN-9849][VL] Reenable native might_contain evaluation that was disabled in #9850 #10240
Merged
Conversation
|
Run Gluten ClickHouse CI on ARM |
Member
Author
|
@wForget @jinchengchenghh Thanks |
|
Run Gluten ClickHouse CI on ARM |
|
Run Gluten ClickHouse CI on ARM |
|
Run Gluten ClickHouse CI on ARM |
|
Run Gluten ClickHouse CI on ARM |
|
Run Gluten ClickHouse CI on ARM |
| extends BinaryExpression | ||
| with GlutenTaskOnlyExpression { | ||
| extends BinaryExpression { | ||
| import VeloxBloomFilterMightContain._ |
Contributor
There was a problem hiding this comment.
Do we import here?
Member
Author
There was a problem hiding this comment.
Yes, for SerializableDirectByteBuffer.
jinchengchenghh
approved these changes
Jul 23, 2025
Member
Author
|
Thanks @wForget @jinchengchenghh! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following: #9850
Velox PR needed: facebookincubator/velox#13955
In #9850 we have disabled native
might_containin some cases where the expression is evaluated on Spark driver.The patch uses static evaluation of
might_containfor such cases and re-enable the native code path.