[VL] Make bloom_filter_agg fall back when might_contain is not transformable#3994
Merged
Merged
Conversation
Contributor
Author
|
cc @zhouyuan , @baibaichen , thanks. |
|
Run Gluten Clickhouse CI |
Member
|
CC: @loneylee |
|
Run Gluten Clickhouse CI |
14d9979 to
301d4ed
Compare
|
Run Gluten Clickhouse CI |
Contributor
Author
|
@zhouyuan , @baibaichen , are you ok to reapply this change? |
zhouyuan
reviewed
Dec 11, 2023
| } | ||
| } | ||
|
|
||
| plan.transformExpressions { |
Member
There was a problem hiding this comment.
@zhli1142015 is this the key change?
Fix the issue only might_contain fallback.
Contributor
|
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
This was referenced Apr 17, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
How was this patch tested?
UT.