Skip to content

[CORE] Make it clear that expand-partitioning only involves in inner-like joins #4456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhztheplayer merged 1 commit into from
Jan 22, 2024
Merged

[CORE] Make it clear that expand-partitioning only involves in inner-like joins #4456

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions gluten-core/src/main/scala/io/glutenproject/execution/HashJoinExecTransformer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,8 @@ trait HashJoinLikeExecTransformer
override def outputPartitioning: Partitioning = joinBuildSide match {
case BuildLeft =>
joinType match {
case _: InnerLike | RightOuter => expandPartitioning(right.outputPartitioning)
case _: InnerLike => expandPartitioning(right.outputPartitioning)
case RightOuter => right.outputPartitioning
case LeftOuter => left.outputPartitioning
case FullOuter => UnknownPartitioning(left.outputPartitioning.numPartitions)
case x =>
Expand All @@ -180,8 +181,8 @@ trait HashJoinLikeExecTransformer
}
case BuildRight =>
joinType match {
case _: InnerLike | LeftOuter | LeftSemi | LeftAnti | _: ExistenceJoin =>
expandPartitioning(left.outputPartitioning)
case _: InnerLike => expandPartitioning(left.outputPartitioning)
case LeftOuter | LeftSemi | LeftAnti | _: ExistenceJoin => left.outputPartitioning
case RightOuter => right.outputPartitioning
case FullOuter => UnknownPartitioning(right.outputPartitioning.numPartitions)
case x =>
Expand Down