[GLUTEN-7749][VL] Trim ISOControl characters in string for casting to integral type#7806
Merged
Conversation
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
jackylee-ch
reviewed
Nov 5, 2024
|
Run Gluten Clickhouse CI on x86 |
1 similar comment
Member
Author
|
Run Gluten Clickhouse CI on x86 |
jackylee-ch
approved these changes
Nov 5, 2024
jackylee-ch
left a comment
jackylee-ch
left a comment
Contributor
There was a problem hiding this comment.
Basically look good to me. @philo-he any more comments?
philo-he
reviewed
Nov 6, 2024
| // Needs to be trimmed for casting to float/double/decimal | ||
| val trimSpaceStr = ('\u0000' to '\u0020').toList.mkString | ||
| // ISOControl characters, refer java.lang.Character.isISOControl(int) | ||
| val isoControlControlStr = (('\u0000' to '\u001F') ++ ('\u007F' to '\u009F')).toList.mkString |
Member
There was a problem hiding this comment.
isoControlControlStr->isoControlStr, a typo?
|
Run Gluten Clickhouse CI on x86 |
Member
|
@wForget, I see. What I checked is Spark-3.3.1, which doesn't cover that change. Let's note this is not applicable to all supported Spark versions. But I think it may be acceptable to end users. |
philo-he
approved these changes
Nov 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fixes: #7749, to align with Spark's change introduced by apache/spark#41535.
How was this patch tested?
added unit test