HADOOP-16835. Recover from all failures loading openssl native libs.#1827
Closed
steveloughran wants to merge 1 commit into
Closed
HADOOP-16835. Recover from all failures loading openssl native libs.#1827steveloughran wants to merge 1 commit into
steveloughran wants to merge 1 commit into
Conversation
Change-Id: I6bdf8ac7a2a8ee82eda3eadac20f03888af24496
Contributor
Author
|
ran the abfs tests; failures fixed in #1821 and the "no http support " test, otherwise all good |
Contributor
Author
|
💔 -1 overall
This message was automatically generated. |
sahilTakiar
reviewed
Feb 5, 2020
| LOG.debug("Failed to load OpenSSL. Falling back to the JSSE default."); | ||
| ctx = SSLContext.getDefault(); | ||
| channelMode = SSLChannelMode.Default_JSSE; | ||
| } catch (Exception e) { |
Contributor
There was a problem hiding this comment.
should we remove the catch block for the NoSuchAlgorithmException and just let all exceptions be handled by the same block? these changes look useful for the NoSuchAlgorithmException as well
Contributor
Author
|
superceded by #1948 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fallback is the same as that for a no-algorithm, the difference this is logged. That's because this a sign of a more serious problem and I think we do need it in the logs.