HADOOP-16855. Changing wildfly dependency scope in hadoop-azure to compile

[bilaharith]

No description provided.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
+1 💚	mvninstall	22m 35s	trunk passed
+1 💚	compile	0m 27s	trunk passed
+1 💚	mvnsite	0m 30s	trunk passed
+1 💚	shadedclient	38m 57s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 22s	trunk passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 26s	the patch passed
+1 💚	compile	0m 23s	the patch passed
+1 💚	javac	0m 23s	the patch passed
+1 💚	mvnsite	0m 25s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 2s	The patch has no ill-formed XML file.
+1 💚	shadedclient	15m 16s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 20s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 9s	hadoop-azure in the patch passed.
+1 💚	asflicense	0m 28s	The patch does not generate ASF License warnings.
		60m 23s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1929/2/artifact/out/Dockerfile
GITHUB PR	#1929
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml
uname	Linux d2a7d99bbeb1 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / c613296
Default Java	1.8.0_242
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1929/2/testReport/
Max. process+thread count	308 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1929/2/console
versions	git=2.7.4 maven=3.3.9
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

[bilaharith]

Driver test results using accounts in Central India
mvn -T 1C -Dparallel-tests=abfs -Dscale -DtestsThreadCount=8 clean verify

Account with HNS Support
[INFO] Tests run: 52, Failures: 0, Errors: 0, Skipped: 0
[WARNING] Tests run: 416, Failures: 0, Errors: 0, Skipped: 66
[WARNING] Tests run: 206, Failures: 0, Errors: 0, Skipped: 24

Account without HNS support
[INFO] Tests run: 52, Failures: 0, Errors: 0, Skipped: 0
[WARNING] Tests run: 416, Failures: 0, Errors: 0, Skipped: 240
[WARNING] Tests run: 206, Failures: 0, Errors: 0, Skipped: 24

[snvijaya]

+1

[DadanielZ]

Plz add the description

[steveloughran]

It's not mandatory for hadoop-azure though, is it?
if you want it in the hadoop-dist packaging, let's add it there

[steveloughran]

OK, I understand now; it's a regression from HADOOP-16346 -and the change spans hadoop-aws too, which now has acquired a mandatory dependency on wildfly

-1 to this patch as is as we need something to cut out that wildfly jar dependency entirely

I'll include this specific change in there so that you get it in your dependencies, even after we add some classloader resilience to wildfly use

[steveloughran]

see #1948

I don't see that this is needed, as it should be propagating downstream. Have you been seeing this in trunk or elsewhere?

Use mvn dependency:tree -Dverbose to get that dependency graph

[bilaharith]

ee that this is needed, as it should be propagating downst

Ran the command from both the feature branch and trunk.