HDFS-16008. RBF: Tool to initialize ViewFS Mapping to Router#2981
Closed
zhuxiangyi wants to merge 11 commits into
Closed
HDFS-16008. RBF: Tool to initialize ViewFS Mapping to Router#2981zhuxiangyi wants to merge 11 commits into
zhuxiangyi wants to merge 11 commits into
Conversation
goiri
changed the title
goiri
reviewed
May 6, 2021
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
@goiri Thank you for your detailed review. I will modify and add unit tests according to your comments. |
|
💔 -1 overall
This message was automatically generated. |
goiri
reviewed
May 6, 2021
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
goiri
reviewed
May 7, 2021
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
goiri
reviewed
May 11, 2021
|
💔 -1 overall
This message was automatically generated. |
goiri
approved these changes
May 12, 2021
Hexiaoqiao
reviewed
May 13, 2021
Hexiaoqiao
left a comment
Hexiaoqiao
left a comment
Contributor
There was a problem hiding this comment.
Thanks @zhuxiangyi for your works. Leave some comments inline.
| String[] nss = new String[]{destUri.getAuthority()}; | ||
| boolean added = addMount( | ||
| mount, nss, destUri.getPath(), false, | ||
| false, order, getACLEntityFormHdfsPath(path, getConf())); |
Contributor
There was a problem hiding this comment.
if we specify clustername, it could be not proper to invoke directly, right?
Contributor
Author
There was a problem hiding this comment.
@Hexiaoqiao I didn't find any problems here, can you tell me the details, thank you very much.
| mode = fileStatus.getPermission(); | ||
| } | ||
| } catch (IOException e) { | ||
| System.err.println("Exception encountered " + e); |
Contributor
There was a problem hiding this comment.
just suggest to throw exception rather than just print the error information.
Contributor
Author
There was a problem hiding this comment.
When FileStatus cannot be obtained, I think the default ACLEntity should be used to add the mapping.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Contributor
|
We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HDFS-16008