YARN-11158. Support (Create/Renew/Cancel) DelegationToken API's for Federation.#5104
Conversation
…elegationToken API's for Federation.
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
@goiri Can you help review this pr? Thank you very much! |
|
🎊 +1 overall
This message was automatically generated. |
|
@goiri Can you help review this pr? Thank you very much! |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
| public void setNumSubmitRetries(int numSubmitRetries) { | ||
| this.numSubmitRetries = numSubmitRetries; | ||
| } | ||
|
|
There was a problem hiding this comment.
Thank you very much for reviewing the code, I will fix it.
| } | ||
|
|
||
| try { | ||
|
|
| interceptor.setTokenSecretManager(tokenSecretManager); | ||
| } catch (Exception e) { | ||
| LOG.error(e.getMessage()); | ||
| Assert.fail(); |
There was a problem hiding this comment.
Why not just let the exception surface?
There was a problem hiding this comment.
Thanks for your suggestion, I will modify the code.
| YarnConfiguration.RM_DELEGATION_TOKEN_RENEW_INTERVAL_KEY, | ||
| YarnConfiguration.RM_DELEGATION_TOKEN_RENEW_INTERVAL_DEFAULT); | ||
| long renewDate = delegationTokenState.get(rMDelegationTokenIdentifier); | ||
| Assert.assertEquals((issueDate + tokenRenewInterval), renewDate); |
There was a problem hiding this comment.
No need for internal parenthesis.
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
@goiri Thank you very much for helping to review the code! Can you help me merge this pr into the trunk branch? I will continue to follow up YARN-11225. [Federation] Add postDelegationToken, postDelegationTokenExpiration, cancelDelegationToken REST APIs for Router. |
|
@goiri Thank you very much for helping to review the code! |
JIRA: YARN-11158. Support getDelegationToken, renewDelegationToken, cancelDelegationToken API's for Federation.