HADOOP-19049. Fix StatisticsDataReferenceCleaner classloader leak by Hisoka-X · Pull Request #6488 · apache/hadoop

Hisoka-X · 2024-01-23T12:19:38Z

Description of PR

This PR fix StatisticsDataReferenceCleaner thread class loader leak problem. Before start it we should make sure it can not reference class loader.

How was this patch tested?

Add new test.

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

hadoop-yetus · 2024-01-23T15:53:14Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 32s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	41m 17s		trunk passed
+1 💚	compile	16m 3s		trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	compile	14m 41s		trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	checkstyle	1m 12s		trunk passed
+1 💚	mvnsite	1m 34s		trunk passed
+1 💚	javadoc	1m 10s		trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 48s		trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	spotbugs	2m 28s		trunk passed
+1 💚	shadedclient	34m 2s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 51s		the patch passed
+1 💚	compile	17m 34s		the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javac	17m 34s		the patch passed
+1 💚	compile	15m 41s		the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	javac	15m 41s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 7s		the patch passed
+1 💚	mvnsite	1m 34s		the patch passed
+1 💚	javadoc	1m 5s		the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 48s		the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	spotbugs	2m 36s		the patch passed
+1 💚	shadedclient	34m 10s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	19m 16s		hadoop-common in the patch passed.
+1 💚	asflicense	0m 55s		The patch does not generate ASF License warnings.
		212m 17s

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6488/1/artifact/out/Dockerfile
GITHUB PR	#6488
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 67514ebd8601 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `47532b7`
Default Java	Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6488/1/testReport/
Max. process+thread count	3152 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6488/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

steveloughran

worried about the risks...what does setting the value to null do
testing?

steveloughran · 2024-01-29T17:25:07Z

      STATS_DATA_CLEANER.
          setName(StatisticsDataReferenceCleaner.class.getName());
      STATS_DATA_CLEANER.setDaemon(true);
+      STATS_DATA_CLEANER.setContextClassLoader(null);


what are the risks of setting this to null?

If the thread relies on the return value of Thread.currentThread().getContextClassLoader() for logical processing, it may encounter NPE, but I checked the corresponding code. This risk should not exist. In fact, this is a normal way of handling classloader references in the daemon thread. You can refer https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-7008595

Hisoka-X · 2024-01-30T02:31:32Z

testing?

Adding...

steveloughran · 2024-01-30T13:15:00Z

those java links have convinced me; StreamCloser in the jdk does exactly this.

If you can do a test for this -fine. but it may be too hard to write a test for...in which case I will merge as is

hadoop-yetus · 2024-02-01T16:02:12Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 49s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	46m 50s		trunk passed
+1 💚	compile	18m 27s		trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	compile	16m 35s		trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	checkstyle	1m 16s		trunk passed
+1 💚	mvnsite	1m 39s		trunk passed
+1 💚	javadoc	1m 13s		trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 50s		trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	spotbugs	2m 32s		trunk passed
+1 💚	shadedclient	40m 51s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 54s		the patch passed
+1 💚	compile	17m 43s		the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javac	17m 43s		the patch passed
+1 💚	compile	16m 35s		the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	javac	16m 35s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 11s		the patch passed
+1 💚	mvnsite	1m 37s		the patch passed
+1 💚	javadoc	1m 4s		the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 50s		the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	spotbugs	2m 42s		the patch passed
+1 💚	shadedclient	39m 45s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	19m 22s		hadoop-common in the patch passed.
+1 💚	asflicense	0m 57s		The patch does not generate ASF License warnings.
		236m 40s

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6488/4/artifact/out/Dockerfile
GITHUB PR	#6488
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 25e24de0441c 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `114bd63`
Default Java	Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6488/4/testReport/
Max. process+thread count	3135 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6488/4/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

steveloughran

+1

) Contributed by Jia Fan

…ache#6488) Contributed by Jia Fan

) Contributed by Jia Fan

HADOOP-19049. Fix StatisticsDataReferenceCleaner classloader leak

47532b7

github-actions Bot added trunk Common labels Jan 23, 2024

steveloughran reviewed Jan 29, 2024

View reviewed changes

Hisoka-X added 2 commits February 1, 2024 10:42

update

496ed2c

update

b4502bc

steveloughran requested changes Feb 1, 2024

View reviewed changes

Comment thread ...mon-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileSystemContractBaseTest.java Outdated

update

114bd63

steveloughran approved these changes Feb 3, 2024

View reviewed changes

steveloughran merged commit 4f0f5a5 into apache:trunk Feb 3, 2024

asfgit pushed a commit that referenced this pull request Feb 3, 2024

HADOOP-19049. Fix StatisticsDataReferenceCleaner classloader leak (#6488

36c15c5

) Contributed by Jia Fan

jiajunmao pushed a commit to jiajunmao/hadoop-MLEC that referenced this pull request Feb 6, 2024

HADOOP-19049. Fix StatisticsDataReferenceCleaner classloader leak (ap…

b736fb1

…ache#6488) Contributed by Jia Fan

slfan1989 pushed a commit that referenced this pull request Feb 10, 2024

HADOOP-19049. Fix StatisticsDataReferenceCleaner classloader leak (#6488

d6c66f7

) Contributed by Jia Fan

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HADOOP-19049. Fix StatisticsDataReferenceCleaner classloader leak#6488

HADOOP-19049. Fix StatisticsDataReferenceCleaner classloader leak#6488
steveloughran merged 4 commits into
apache:trunkfrom
Hisoka-X:fix-stats-classloader

Hisoka-X commented Jan 23, 2024 •

edited

Loading

Uh oh!

hadoop-yetus commented Jan 23, 2024

Uh oh!

steveloughran left a comment

Uh oh!

steveloughran Jan 29, 2024

Uh oh!

Hisoka-X Jan 30, 2024

Uh oh!

Hisoka-X commented Jan 30, 2024

Uh oh!

steveloughran commented Jan 30, 2024

Uh oh!

Uh oh!

hadoop-yetus commented Feb 1, 2024

Uh oh!

steveloughran left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Hisoka-X commented Jan 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

How was this patch tested?

For code changes:

Uh oh!

hadoop-yetus commented Jan 23, 2024

Uh oh!

steveloughran left a comment

Choose a reason for hiding this comment

Uh oh!

steveloughran Jan 29, 2024

Choose a reason for hiding this comment

Uh oh!

Hisoka-X Jan 30, 2024

Choose a reason for hiding this comment

Uh oh!

Hisoka-X commented Jan 30, 2024

Uh oh!

steveloughran commented Jan 30, 2024

Uh oh!

Uh oh!

hadoop-yetus commented Feb 1, 2024

Uh oh!

steveloughran left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Hisoka-X commented Jan 23, 2024 •

edited

Loading