HADOOP-19548: [ABFS] Fix Logging in FSDataInputStream to Mention Correct Buffersize#7642
Merged
Merged
Conversation
|
💔 -1 overall
This message was automatically generated. |
anujmodi2021
left a comment
anujmodi2021
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Just a minor suggestion for logging.
| public FSDataInputStream open(final Path path, final int bufferSize) throws IOException { | ||
| LOG.debug("AzureBlobFileSystem.open path: {} bufferSize: {}", path, bufferSize); | ||
| // bufferSize is unused. | ||
| LOG.debug("AzureBlobFileSystem.open path: {} bufferSize: {}", path, |
Contributor
There was a problem hiding this comment.
Trying to understand this from a user's perspective. If someone is calling this method with a buffer size they expect that buffer size to get honoured and if they really want that buffer size to be honored they should know how to make that happen.
Let's add debug something like this: AzureBlobFileSystem.open path: {} bufferSize as configured in "fs.azure.read.request.size": {}", path, abfsStore.getAbfsConfiguration().getReadBufferSize())
Contributor
Author
There was a problem hiding this comment.
Makes sense, taken
Contributor
|
We might need to add some tests to pass the Yetus checks. You can verify that whatever parameter we pass, the buffer size is always what is configured. |
anmolanmol1234
approved these changes
Apr 24, 2025
|
|
||
| abfsConfig.setReadBufferSize(bufferSizeConfig); | ||
| fs.open(testPath, bufferSizeArg); | ||
| int actualBufferSize = abfsConfig.getReadBufferSize(); |
Contributor
There was a problem hiding this comment.
To assert we should take bufer size from the FSDataInputStream not the configs.
Configs we are only setting so that is bound to be same
Contributor
Author
There was a problem hiding this comment.
Makes sense, corrected
| public void testBufferSizeSet() throws Exception { | ||
| final AzureBlobFileSystem fs = getFileSystem(); | ||
| AbfsConfiguration abfsConfig = fs.getAbfsStore().getAbfsConfiguration(); | ||
| int bufferSizeConfig = 5 * 1024 * 1024; |
Contributor
There was a problem hiding this comment.
Let's use constants here like "ONE_MB"
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
manika137
force-pushed
the
HADOOP-19548_fixlog
branch
from
e2ff769 to
8df1b5b
Compare
|
🎊 +1 overall
This message was automatically generated. |
manika137
added a commit
to ABFSDriver/AbfsHadoop
that referenced
this pull request
Apr 30, 2025
…ect Buffersize (apache#7642) Contributed by: Manika Joshi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
JIRA: https://issues.apache.org/jira/browse/HADOOP-19548
Small change to fix logging in FSDataInputStream and mention the correct buffersize being used.
How was this patch tested?
No production change made- only changed the logging. Test runs not required.