Skip to content

Minor improvements to the README of hbck2#138

Merged
lfrancke merged 4 commits into
apache:masterfrom
lfrancke:doc-fixes
Nov 22, 2023
Merged

Minor improvements to the README of hbck2#138
lfrancke merged 4 commits into
apache:masterfrom
lfrancke:doc-fixes

Conversation

@lfrancke
Copy link
Copy Markdown
Member

@lfrancke lfrancke commented Nov 8, 2023

No description provided.

wchevreuil
wchevreuil approved these changes Nov 8, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@wchevreuil wchevreuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor nit.

Comment thread hbase-hbck2/README.md Outdated
workings of an hbase-2.x.
HBCK2 is the successor to [hbck](https://hbase.apache.org/book.html#hbck.in.depth), the repair tool that shipped with _HBase 1.x_ (A.K.A _hbck1_).
Use _HBCK2_ in place of _hbck1_ making repairs against hbase-2.x clusters.
_hbck1_ should not be run against an HBase 2.x installation as it may to damage.
Copy link
Copy Markdown
Contributor

@wchevreuil wchevreuil Nov 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: "may do damage"

Copy link
Copy Markdown
Member Author

@lfrancke lfrancke Nov 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I totally missed this review!

@Apache-HBase
Copy link
Copy Markdown

Apache-HBase commented Nov 8, 2023

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 43s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 markdownlint 0m 0s markdownlint was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 30s Maven dependency ordering for branch
+1 💚 spotless 0m 10s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 3s Maven dependency ordering for patch
+1 💚 shellcheck 0m 0s There were no new shellcheck issues.
-1 ❌ whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-1 ❌ spotless 0m 3s patch has 22 errors when running spotless:check, run spotless:apply to fix.
_ Other Tests _
+1 💚 asflicense 0m 13s The patch does not generate ASF License warnings.
2m 59s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-138/1/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR #138
Optional Tests dupname asflicense spotless markdownlint shellcheck shelldocs
uname Linux 545ecf54b405 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 GNU/Linux
Build tool maven
Personality dev-support/jenkins/hbase-personality.sh
git revision master / a4af0cc
whitespace https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-138/1/artifact/yetus-precommit-check/output/whitespace-eol.txt
spotless https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-138/1/artifact/yetus-precommit-check/output/patch-spotless.txt
Max. process+thread count 34 (vs. ulimit of 5000)
modules C: hbase-hbck2 . U: .
Console output https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-138/1/console
versions git=2.30.2 maven=3.8.6 shellcheck=0.7.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link
Copy Markdown

Apache-HBase commented Nov 21, 2023

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 8s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 markdownlint 0m 0s markdownlint was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 25s Maven dependency ordering for branch
+1 💚 spotless 0m 6s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 2s Maven dependency ordering for patch
+1 💚 shellcheck 0m 0s There were no new shellcheck issues.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 spotless 0m 5s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 11s The patch does not generate ASF License warnings.
2m 13s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-138/2/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR #138
Optional Tests dupname asflicense spotless markdownlint shellcheck shelldocs
uname Linux 4801bd0ae502 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 GNU/Linux
Build tool maven
Personality dev-support/jenkins/hbase-personality.sh
git revision master / a4af0cc
Max. process+thread count 34 (vs. ulimit of 5000)
modules C: hbase-hbck2 . U: .
Console output https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-138/2/console
versions git=2.30.2 maven=3.8.6 shellcheck=0.7.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@lfrancke lfrancke requested a review from wchevreuil November 21, 2023 14:32
@Apache-HBase
Copy link
Copy Markdown

Apache-HBase commented Nov 21, 2023

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 25s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 markdownlint 0m 0s markdownlint was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 20s Maven dependency ordering for branch
+1 💚 spotless 0m 6s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 3s Maven dependency ordering for patch
+1 💚 shellcheck 0m 0s There were no new shellcheck issues.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 spotless 0m 4s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 11s The patch does not generate ASF License warnings.
1m 25s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-138/3/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR #138
Optional Tests dupname asflicense spotless markdownlint shellcheck shelldocs
uname Linux be7d59696d5e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 GNU/Linux
Build tool maven
Personality dev-support/jenkins/hbase-personality.sh
git revision master / a4af0cc
Max. process+thread count 34 (vs. ulimit of 5000)
modules C: hbase-hbck2 . U: .
Console output https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-138/3/console
versions git=2.30.2 maven=3.8.6 shellcheck=0.7.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@lfrancke lfrancke merged commit 4d4c928 into apache:master Nov 22, 2023
ksravista pushed a commit to HubSpot/hbase-operator-tools that referenced this pull request Jun 20, 2024
@lfrancke
Minor improvements to the README of hbck2 (apache#138)
8b6a0bc 
* Minor improvements to the README of hbck2

* Fix typo and reflow so each sentence is on its own line

* Fix typo and maybe fix whitespace issues as well

* Fix a couple more typos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wchevreuil wchevreuil wchevreuil approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lfrancke @Apache-HBase @wchevreuil