Skip to content

HBASE-28375 HBase Operator Tools fails to compile with hbase 2.6.0 #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NihalJain merged 1 commit into from
Feb 18, 2024
Merged

HBASE-28375 HBase Operator Tools fails to compile with hbase 2.6.0 #140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 28 additions & 1 deletion hbase-hbck2/src/main/java/org/apache/hbase/hbck1/ReplicationChecker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,17 @@
*/
package org.apache.hbase.hbck1;

import java.io.IOException;
import java.lang.reflect.InvocationTargetException;
import java.lang.reflect.Method;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.HashSet;
import java.util.List;
import java.util.Map;
import java.util.Set;
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.fs.FileSystem;
import org.apache.hadoop.hbase.ServerName;
import org.apache.hadoop.hbase.replication.ReplicationException;
import org.apache.hadoop.hbase.replication.ReplicationPeerStorage;
Expand Down Expand Up @@ -55,11 +59,34 @@ public class ReplicationChecker {

public ReplicationChecker(Configuration conf, ZKWatcher zkw,
HBaseFsck.ErrorReporter errorReporter) {
this.peerStorage = ReplicationStorageFactory.getReplicationPeerStorage(zkw, conf);
this.peerStorage = getReplicationPeerStorage(conf, zkw);
this.queueStorage = ReplicationStorageFactory.getReplicationQueueStorage(zkw, conf);
this.errorReporter = errorReporter;
}

private ReplicationPeerStorage getReplicationPeerStorage(Configuration conf, ZKWatcher zkw)
throws AssertionError {
ReplicationPeerStorage peerStorage;
try {
// Case HBase >= 2.6.0: Invoke the method that requires three parameters
Method method = ReplicationStorageFactory.class.getMethod("getReplicationPeerStorage",
FileSystem.class, ZKWatcher.class, Configuration.class);
FileSystem fileSystem = FileSystem.get(conf);
peerStorage = (ReplicationPeerStorage) method.invoke(null, fileSystem, zkw, conf);
} catch (IOException | NoSuchMethodException | IllegalAccessException
| InvocationTargetException e1) {
// Case HBase < 2.6.0: Fall back to the method that requires only two parameters
try {
Method method = ReplicationStorageFactory.class.getMethod("getReplicationPeerStorage",
ZKWatcher.class, Configuration.class);
peerStorage = (ReplicationPeerStorage) method.invoke(null, zkw, conf);
} catch (NoSuchMethodException | IllegalAccessException | InvocationTargetException e2) {
throw new AssertionError("should not happen", e2);
}
}
return peerStorage;
}

public boolean hasUnDeletedQueues() {
return errorReporter.getErrorList()
.contains(HBaseFsck.ErrorReporter.ERROR_CODE.UNDELETED_REPLICATION_QUEUE);
Expand Down