HBASE-29635 HBCK scheduleRecoveries incompatible with HBase 3#152
Merged
Conversation
wchevreuil
approved these changes
Sep 30, 2025
|
💔 -1 overall
This message was automatically generated. |
Apache9
reviewed
Sep 30, 2025
| put(BYPASS, Arrays.asList("bypassProcedure")); | ||
| put(SCHEDULE_RECOVERIES, | ||
| Arrays.asList("scheduleServerCrashProcedure", "scheduleServerCrashProcedures")); | ||
| Arrays.asList("scheduleServerCrashProcedures")); |
Contributor
There was a problem hiding this comment.
This is a command? Is it OK to remove a command?
Contributor
Author
There was a problem hiding this comment.
This is a compatibility check for the Hbck interface for the commands availability. When the server does not have the specified command it will thrown and UnsupportedOperationException to the operator but it can be ignored with the skip flag.
The scheduleServerCrashProcedure got deprecated in 2.2.1 so older HBase verisons will not be compatible with this HBCK.
Contributor
There was a problem hiding this comment.
Then I think if we still want HBCK to support hbase 2.2.1-, we should keep this command here? For newer hbase versions, we could use scheduleServerCrashProcedures?
Contributor
Author
There was a problem hiding this comment.
This removal doesn't mean HBCK would work with an older HBase, this would just throw the exception before calling the method. The change in this line is relevant: https://github.com/apache/hbase-operator-tools/pull/152/files#diff-2b2dc12521ea8fad10d0e53fa0ce78fc7dd3037a648a3e5c5547948e76511afdR596
However, there are other incompatibilities with HBase 3.0 and resolving them would be difficult to keep it compatible with older versions. I started to collect them in HBASE-29638
Contributor
Author
There was a problem hiding this comment.
@Apache9 Please take a look. I kept the old version support with reflection.
|
🎊 +1 overall
This message was automatically generated. |
mnpoonia
approved these changes
Sep 30, 2025
Contributor
Author
|
I kept support for old HBase version with reflection and tested it with 2.2.0 version. |
|
🎊 +1 overall
This message was automatically generated. |
chandrasekhar-188k
approved these changes
Oct 5, 2025
Contributor
|
Sorry for the late reply... Thanks @petersomogyi and others! Let me prepare a new RC for hbase-operator-tools. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.