Skip to content

Add ZooKeeperAccessor to helix-rest#671

Merged
narendly merged 10 commits into
apache:masterfrom
narendly:rest0
Jan 16, 2020
Merged

Add ZooKeeperAccessor to helix-rest#671
narendly merged 10 commits into
apache:masterfrom
narendly:rest0

Conversation

@narendly
Copy link
Copy Markdown
Contributor

@narendly narendly commented Dec 24, 2019

Issues

  • My PR addresses the following Helix issues and references them in the PR description:

Fixes #667
Fixes #668
Fixes #669

Description

  • Here are some details about my PR, including screenshots of any UI changes:

In order to provide basic ZkClient functionalities (CRUD) in helix-rest, we want to add a ZooKeeperAccessor class that supports endpoints like get(), getChildren(), and exists().

Changelist:

  1. Fix the double-checked locking idiom for byte array ZkBaseDataAccessor
  2. Add ZooKeeperAccessor
  3. Add tests

Tests

  • The following tests are written for this issue:

TestZooKeeperAccessor.java

  • The following is the result of the "mvn test" command on the appropriate module:

[INFO] Tests run: 93, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 21.96 s - in TestSuite
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 93, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 27.300 s
[INFO] Finished at: 2020-01-13T10:02:47-08:00
[INFO] ------------------------------------------------------------------------

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • My diff has been formatted using helix-style.xml

@narendly narendly marked this pull request as ready for review January 13, 2020 08:32
Comment thread helix-rest/src/test/java/org/apache/helix/rest/server/TestZooKeeperAccessor.java Outdated
Comment thread helix-rest/src/main/java/org/apache/helix/rest/server/ServerContext.java Outdated
Copy link
Copy Markdown
Contributor

@jiajunwang jiajunwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Just one minor comment, which is optional.

@narendly
Copy link
Copy Markdown
Contributor Author

This PR is ready to be merged, approved by @jiajunwang

@narendly
Copy link
Copy Markdown
Contributor Author

Final commit message:

Add ZooKeeperAccessor to helix-rest

In order to provide basic ZkClient functionalities (CRUD) in helix-rest, we want to add a ZooKeeperAccessor class that supports endpoints like get(), getChildren(), and exists().

Changelist:

Fix the double-checked locking idiom for byte array ZkBaseDataAccessor
Add ZooKeeperAccessor
Add tests

@narendly narendly merged commit 1560130 into apache:master Jan 16, 2020
mgao0 pushed a commit to mgao0/helix that referenced this pull request Jan 21, 2020
In order to provide basic ZkClient functionalities in helix-rest, we want to add a ZooKeeperAccessor class that supports endpoints like get(), getChildren(), and exists().

Changelist:
1. Fix the double-checked locking idiom for byte array ZkBaseDataAccessor
2. Add ZooKeeperAccessor
3. Add tests
narendly added a commit to narendly/helix that referenced this pull request Feb 9, 2020
In order to provide basic ZkClient functionalities in helix-rest, we want to add a ZooKeeperAccessor class that supports endpoints like get(), getChildren(), and exists().

Changelist:
1. Fix the double-checked locking idiom for byte array ZkBaseDataAccessor
2. Add ZooKeeperAccessor
3. Add tests
narendly added a commit to narendly/helix that referenced this pull request Feb 9, 2020
In order to provide basic ZkClient functionalities in helix-rest, we want to add a ZooKeeperAccessor class that supports endpoints like get(), getChildren(), and exists().

Changelist:
1. Fix the double-checked locking idiom for byte array ZkBaseDataAccessor
2. Add ZooKeeperAccessor
3. Add tests
mgao0 pushed a commit to mgao0/helix that referenced this pull request Mar 6, 2020
In order to provide basic ZkClient functionalities in helix-rest, we want to add a ZooKeeperAccessor class that supports endpoints like get(), getChildren(), and exists().

Changelist:
1. Fix the double-checked locking idiom for byte array ZkBaseDataAccessor
2. Add ZooKeeperAccessor
3. Add tests
huizhilu pushed a commit to huizhilu/helix that referenced this pull request Aug 16, 2020
In order to provide basic ZkClient functionalities in helix-rest, we want to add a ZooKeeperAccessor class that supports endpoints like get(), getChildren(), and exists().

Changelist:
1. Fix the double-checked locking idiom for byte array ZkBaseDataAccessor
2. Add ZooKeeperAccessor
3. Add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a path-based getChildren() to helix-rest Add a path-based exists() to helix-rest Add a path-based get() to helix-rest

4 participants