Add ZooKeeperAccessor to helix-rest#671
Merged
Merged
Conversation
huizhilu
reviewed
Jan 13, 2020
NealSun96
reviewed
Jan 13, 2020
huizhilu
reviewed
Jan 14, 2020
jiajunwang
reviewed
Jan 15, 2020
huizhilu
reviewed
Jan 15, 2020
jiajunwang
reviewed
Jan 15, 2020
jiajunwang
approved these changes
Jan 16, 2020
Contributor
jiajunwang
left a comment
There was a problem hiding this comment.
LGTM!
Just one minor comment, which is optional.
Contributor
Author
|
This PR is ready to be merged, approved by @jiajunwang |
Contributor
Author
|
Final commit message: Add ZooKeeperAccessor to helix-rest In order to provide basic ZkClient functionalities (CRUD) in helix-rest, we want to add a ZooKeeperAccessor class that supports endpoints like get(), getChildren(), and exists(). Changelist: Fix the double-checked locking idiom for byte array ZkBaseDataAccessor |
mgao0
pushed a commit
to mgao0/helix
that referenced
this pull request
Jan 21, 2020
In order to provide basic ZkClient functionalities in helix-rest, we want to add a ZooKeeperAccessor class that supports endpoints like get(), getChildren(), and exists(). Changelist: 1. Fix the double-checked locking idiom for byte array ZkBaseDataAccessor 2. Add ZooKeeperAccessor 3. Add tests
narendly
added a commit
to narendly/helix
that referenced
this pull request
Feb 9, 2020
In order to provide basic ZkClient functionalities in helix-rest, we want to add a ZooKeeperAccessor class that supports endpoints like get(), getChildren(), and exists(). Changelist: 1. Fix the double-checked locking idiom for byte array ZkBaseDataAccessor 2. Add ZooKeeperAccessor 3. Add tests
narendly
added a commit
to narendly/helix
that referenced
this pull request
Feb 9, 2020
In order to provide basic ZkClient functionalities in helix-rest, we want to add a ZooKeeperAccessor class that supports endpoints like get(), getChildren(), and exists(). Changelist: 1. Fix the double-checked locking idiom for byte array ZkBaseDataAccessor 2. Add ZooKeeperAccessor 3. Add tests
mgao0
pushed a commit
to mgao0/helix
that referenced
this pull request
Mar 6, 2020
In order to provide basic ZkClient functionalities in helix-rest, we want to add a ZooKeeperAccessor class that supports endpoints like get(), getChildren(), and exists(). Changelist: 1. Fix the double-checked locking idiom for byte array ZkBaseDataAccessor 2. Add ZooKeeperAccessor 3. Add tests
huizhilu
pushed a commit
to huizhilu/helix
that referenced
this pull request
Aug 16, 2020
In order to provide basic ZkClient functionalities in helix-rest, we want to add a ZooKeeperAccessor class that supports endpoints like get(), getChildren(), and exists(). Changelist: 1. Fix the double-checked locking idiom for byte array ZkBaseDataAccessor 2. Add ZooKeeperAccessor 3. Add tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Fixes #667
Fixes #668
Fixes #669
Description
In order to provide basic ZkClient functionalities (CRUD) in helix-rest, we want to add a ZooKeeperAccessor class that supports endpoints like get(), getChildren(), and exists().
Changelist:
Tests
TestZooKeeperAccessor.java
[INFO] Tests run: 93, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 21.96 s - in TestSuite
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 93, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 27.300 s
[INFO] Finished at: 2020-01-13T10:02:47-08:00
[INFO] ------------------------------------------------------------------------
Commits
Code Quality