HIVE-26809: Upgrade ORC to 1.8.3#4121
Conversation
|
Good job! I think you can check previous PR which tried to upgrade ORC to 1.8.1 #3833 |
|
As I see this change mainly contains the new ORC file sizes changes in the tests, and minor code modifications on the hive itself. I do not see to many critical changes here. |
|
I am thinking if we can mask or remove the ORC file sizes related qtest items. In this pr, It is so wasting time to fix qtests about orc file size when upgrading orc version. Also, other OSS eg. Spark seems not treat orc file size as a test item. |
|
I think in a long term we should. Now it is fixed is fine. But you right pretty over checked. I guess we can create a following ticket. Because this sizes check does not protect the code, and It does not create to much value. Also with new ORC's the files would be always different and check manually is just beh. |
|
Sure, i am also ok with this change. Maybe we can create a following ticket to mask orc file size, then we can easily upgrade orc version next time. |
|
Had a minor query which is covered by @abstractdog regarding hadoop-hdfs dependency in beeline pom. |
|
Kudos, SonarCloud Quality Gate passed! |
|
Thank you everyone. It's a great milestone! |








What changes were proposed in this pull request?
Upgrade ORC dependency to 1.8.3.
Why are the changes needed?
ORC version was old, newer version contains many new features like SARG filters.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
By running the tests in the pipeline.