[HUDI-2688][RFC-40] A new Hudi connector for Trino#3957
Merged
Conversation
Member
Author
|
greate @codope thanks for this. i will take a look later this week! |
Member
|
this high level makes sense to me. @codope should we keep this open for further comments or do you plan to add more specific details around how we integrate with hive metastore, what we give up against the hive-connector and any other implementation constraints. |
c57c90d to
ecb89c3
Compare
vinothchandar
approved these changes
Jan 20, 2022
vinothchandar
left a comment
Member
There was a problem hiding this comment.
Left some comments. You can land the RFC once they are addressed!
Add implementation details Update table with new rfc Correct rfc number Add more details related Hudi and split management Mention metadata-based listing Link the rfc in readme Changing status of the RFC Minor edits to the RFC Update connector design Update class hierarchy diagram Update high-def diagram Fix nit Address review comments
Collaborator
liusenhua
pushed a commit
to liusenhua/hudi
that referenced
this pull request
Mar 1, 2022
Add implementation details of a new hudi-trino connector
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Apr 3, 2022
Add implementation details of a new hudi-trino connector
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add implementation details
Update table with new rfc
Tips
What is the purpose of the pull request
(For example: This pull request adds quick-start document.)
Brief change log
(for example:)
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.