Skip to content

feat: implement add column/delete column #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wgtmac merged 5 commits into from
Jan 6, 2026
Merged

feat: implement add column/delete column #486

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b912924
feat: implement add column/delete column
gty404 Jan 4, 2026
585ec90
fix ut failure
gty404 Jan 4, 2026
f79e7b3
fix cpp-linter
gty404 Jan 4, 2026
e5b1be3
fix meson build error
gty404 Jan 5, 2026
d026845
resolve some comments
gty404 Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix ut failure
  • Loading branch information
@gty404
gty404 committed Jan 4, 2026
commit 585ec9061b949d226147fccc388b61d9d5a7c3ac
4 changes: 3 additions & 1 deletion src/iceberg/json_internal.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,9 @@ nlohmann::json ToJson(const SchemaField& field) {
json[kName] = field.name();
json[kRequired] = !field.optional();
json[kType] = ToJson(*field.type());
json[kDoc] = field.doc();
if (!field.doc().empty()) {
json[kDoc] = field.doc();
}
return json;
}

Expand Down
Loading