Skip to content

refactor(util): make retry policy explicit and deterministic#633

Merged
wgtmac merged 3 commits into
apache:mainfrom
wgtmac:refine_retry
May 6, 2026
Merged

refactor(util): make retry policy explicit and deterministic#633
wgtmac merged 3 commits into
apache:mainfrom
wgtmac:refine_retry

Conversation

@wgtmac

@wgtmac wgtmac commented Apr 29, 2026

Copy link
Copy Markdown
Member

No description provided.

Comment thread src/iceberg/test/retry_util_test.cc Outdated

@zhjwpku zhjwpku left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kamcheungting-db kamcheungting-db left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice factor.
I have some non-blocker comments for understanding the underlying intention.

Comment thread src/iceberg/util/retry_util.h
Comment thread src/iceberg/util/retry_util.h
Comment thread src/iceberg/util/retry_util.h
Comment thread src/iceberg/util/retry_util.cc
Comment thread src/iceberg/util/retry_util_internal.h
@wgtmac wgtmac requested a review from zhjwpku May 6, 2026 05:45

@kamcheungting-db kamcheungting-db left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wgtmac

wgtmac commented May 6, 2026

Copy link
Copy Markdown
Member Author

Thanks all for the review!

@wgtmac wgtmac merged commit ff42229 into apache:main May 6, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants