Update the how-to-release page with findings after being a release manager #187
Conversation
|
Hey, Happy New Year, @Fokko and @ajantha-bhat! |
nastra
left a comment
nastra
left a comment
There was a problem hiding this comment.
LGTM with one comment, which would be good to clarify
| Please download, verify, and test. | ||
| Please vote in the next 72 hours. | ||
| Please vote in the next 72 hours. (Weekends excluded) |
There was a problem hiding this comment.
I'm not sure whether that's actually true or not. Might be good to have a definitive answer whether this should be working days vs the next 3 days.
@rdblue I remember you mentioned something around this a while ago, so maybe we could clarify it here
There was a problem hiding this comment.
Apache guidelines
Release votes SHOULD remain open for at least 72 hours.
https://www.apache.org/legal/release-policy.html#release-approval
https://www.apache.org/foundation/voting.html#expressing-votes-1-0-1-and-fractions
There was a problem hiding this comment.
I think it's up to the project to set the length as long as it's at least 3 days. At Impala we found it practical to make this "working days" as people in the community were quite inactive on the weekends for instance and a vote started on Friday usually didn't get enough attention.
There was a problem hiding this comment.
Should we then change this into working days? I think de-facto is already the case.
There was a problem hiding this comment.
@Fokko Yeah, that's a good idea, but then there might be confusion with how to count the national holidays that aren't the same in each country :)
|
|
||
| Decisions about releases are made by three groups: | ||
|
|
||
| * Release Manager: Does the work of creating the release, signing it, counting votes, announcing the release and so on. Doesn't have to be a committer but then should find a committer who helps out with some of the steps. |
There was a problem hiding this comment.
Doesn't have to be a committer but then should find a committer who helps out with some of the steps.
Maybe
Requires the assistance of a committer for some steps.
| Decisions about releases are made by three groups: | ||
|
|
||
| * Release Manager: Does the work of creating the release, signing it, counting votes, announcing the release and so on. Doesn't have to be a committer but then should find a committer who helps out with some of the steps. | ||
| * The community: Performs the discussion of whether it is the right time to create a release and what that release should contain. The community can also cast non-binding votes on the release. |
There was a problem hiding this comment.
We should probably define what "votes on the release" means in this context. May be fine to just link to the Apache Docs
https://www.apache.org/foundation/voting.html
Which has a lot more through information
And https://www.apache.org/legal/release-policy.html
as well
There was a problem hiding this comment.
Thanks for the observation! There is already a section that describes what voting is, also has a link to the Apache voting page. I added a link from this part of the doc to the voting section.
Additionally, I added a link for the apache release-policy page as well.
gaborkaszab
force-pushed
the
update_how_to_release
branch
from
081ae17 to
d0461b9
Compare
gaborkaszab
force-pushed
the
update_how_to_release
branch
from
d0461b9 to
fac9c1f
Compare
|
Hey @Fokko @RussellSpitzer @rdblue ,
|
|
|
||
| * Release Manager: Does the work of creating the release, signing it, counting [votes](/how-to-release/#voting), announcing the release and so on. Requires the assistance of a committer for some steps. | ||
| * The community: Performs the discussion of whether it is the right time to create a release and what that release should contain. The community can also cast non-binding votes on the release. | ||
| * PMC: Gives binding votes on the release. |
There was a problem hiding this comment.
nit: a bit awkward to only put binding vote as a bullet point. Can we move that as a part of the last sentence?
There was a problem hiding this comment.
actually, looks like we also explain binding and non-binding in L221, should we just remove it here?
There was a problem hiding this comment.
Also non-binding votes are mentioned here. The basic idea for this section was to list the roles related to the release process. The community in general can give non-binding votes while the PMC can give binding ones.
Yes, this is also mentioned in L221 but please note, that it is a sample text for the email to be sent out for voting. So in my opinion there is a need to mention the types of voting here and on L221 as well.
| svn ci -m 'Iceberg: Add release <VERSION>' | ||
| ``` | ||
|
|
||
| Note, the above step requires PMC privileges to execute. |
There was a problem hiding this comment.
I think we only need committer level privilege?
There was a problem hiding this comment.
Also we can use !!!Note syntax to format the text
There was a problem hiding this comment.
In fact the step to push the release to SVN requires PMC privileges. I was working together with @Fokko on this and even him didn't have enough permissions so we had to include a PMC member to execute this.
I tried this "!!! Note" syntax, but honestly don't get the point :) This just writes the same in the page. Do I miss something?
jackye1995
left a comment
jackye1995
left a comment
There was a problem hiding this comment.
mostly looks good to me, just a few nits!
gaborkaszab
force-pushed
the
update_how_to_release
branch
from
fac9c1f to
c0c3424
Compare
Thanks for taking a look, @jackye1995 ! I believe I have addressed/answered all of your comments. |
This change is needed to make the sample [VOTE] mail in sync with the changes in the how-to-release pages. apache/iceberg-docs#187
6 participants
There are some obsolete steps, plus some that weren't on the list like revapi to run on the new version, etc.
Also I found some useful information on different Apache projects how-to-release page that I figured would be beneficial to have here, like include in the voting mail some info about binding vs non-binding votes, when the vote passes, etc. Also added an introduction part.