Skip to content

fix: Invert case_sensitive logic in StructType #1147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sungwy merged 4 commits into from
Sep 9, 2024
Merged

fix: Invert case_sensitive logic in StructType #1147

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e9e33c4
fix: Invert logic in StructType
AnthonyLam Sep 8, 2024
38ecf5e
Add test for StructType.field_by_name
AnthonyLam Sep 9, 2024
8d829f5
Remove var I forgot about.
AnthonyLam Sep 9, 2024
31b9d9e
Fix formatting post-lint
AnthonyLam Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove var I forgot about.
  • Loading branch information
@AnthonyLam
AnthonyLam committed Sep 9, 2024
commit 8d829f5361c8fa9277a9de322118b8f297513e4e
2 changes: 1 addition & 1 deletion tests/test_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ def test_struct_type() -> None:
def test_struct_field_by_name() -> None:
lower_field = NestedField(1, "lower_case_field", IntegerType(), required=True),
upper_field = NestedField(2, "UPPER_CASE_FIELD", IntegerType(), required=True),
type_var = StructType(lower_field, upper_field, mixed_field)
type_var = StructType(lower_field, upper_field)

assert type_var.field_by_name("lower_case_field", case_sensitive=False) == lower_field
assert type_var.field_by_name("upper_case_field", case_sensitive=False) == upper_field
Expand Down