Skip to content

abort the whole table transaction if any updates in the transaction has failed #1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevinjqliu merged 4 commits into from
Oct 29, 2024
Merged

abort the whole table transaction if any updates in the transaction has failed #1246

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
945d61d
abort the whole transaction if any update on the chain has failed
Oct 23, 2024
ab8a0a0
Update tests/integration/test_writes/test_writes.py
yingjianwu98 Oct 28, 2024
af5d165
Update tests/integration/test_writes/test_writes.py
yingjianwu98 Oct 28, 2024
fbb7604
add type:ignore to prevent lint error
Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add type:ignore to prevent lint error
  • Loading branch information
Yingjian Wu committed Oct 29, 2024
commit fbb76042f38e0ab0c14b161f45e6151332d3f00e
2 changes: 1 addition & 1 deletion tests/integration/test_writes/test_writes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1471,4 +1471,4 @@ def test_abort_table_transaction_on_exception(
txn.append(arrow_table_with_null) # type: ignore

# Validate the transaction is aborted and no partial update is applied
assert len(tbl.scan().to_pandas()) == table_size
assert len(tbl.scan().to_pandas()) == table_size # type: ignore