-
Notifications
You must be signed in to change notification settings - Fork 444
feat: Support Bucket and Truncate transforms on write #1345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
dd888ec
introduce bucket transform
sungwy bd80f39
include pyiceberg-core
sungwy 27ade9a
introduce bucket transform
sungwy fcd654c
include pyiceberg-core
sungwy a0a9c58
resolve poetry conflict
sungwy a4137e0
Merge branch 'bucket-transform' into bucket-transforms
sungwy 05c440f
support truncate transforms
sungwy 7079265
Remove stale comment
sungwy 77246d5
Merge branch 'main' into bucket-transforms
sungwy c1ece75
fix poetry hash
sungwy 3d0f03b
avoid codespell error for truncate transform
sungwy 1163c2a
Merge branch 'main' into bucket-transforms
sungwy 0e72d90
adopt nits
sungwy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
introduce bucket transform
- Loading branch information
commit dd888ec04a12b56505fe122acdf693a1d9c2a31f
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: wydt of reordering these for readability?
num_buckets,source_typeandinput_arrare configs of the BucketTransform; expected is the outputThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm I think I feel indifferent here - there’s something nice about having the input and expected arrays side by side