fix: Hive catalog test failure on CPython 3.13.12#3043
Merged
Fokko merged 1 commit intoapache:mainfrom Feb 15, 2026
Merged
Conversation
1 task
sumedhsakdeo
left a comment
sumedhsakdeo
left a comment
There was a problem hiding this comment.
Thanks for fixing this @geruh !
robreeves
added a commit
to robreeves/iceberg-python
that referenced
this pull request
Apr 3, 2026
Cherry-pick of apache/iceberg-python#3043. Use reset_mock() instead of directly assigning call_count = 0, which no longer works on CPython 3.13.12.
robreeves
added a commit
to linkedin/iceberg-python
that referenced
this pull request
Apr 3, 2026
* Update GitHub Actions workflow triggers to use li-0.11 branch Replace 'main' with 'li-0.11' in push branch triggers since li-0.11 is the default branch for this fork and main does not exist. * Backport fix for Hive catalog test failure on CPython 3.13.12 Cherry-pick of apache/iceberg-python#3043. Use reset_mock() instead of directly assigning call_count = 0, which no longer works on CPython 3.13.12.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
While reviewing some open PRs #3041, #3042, I noticed CI kept failing on the Python 3.13 job in the hive tests. Turns out CPython 3.13.12 was just released and included a change python/cpython#142651 which made
Mock.call_countthread-safe by deriving it fromlen(call_args_list).This broke our hive test, which was resetting the counter with
mock.call_count = 0directly. This switches to use reset_mock(), which properly clears all the internal call tracking state.Are these changes tested?
make testpassesAre there any user-facing changes?
no