CI looks like broken

[viirya]

https://github.com/apache/iceberg-rust/actions/runs/8323042113/job/22771908103?pr=258

warning: use of deprecated function `arrow_arith::temporal::month_dyn`: Use `date_part` instead
  --> crates/iceberg/src/transform/temporal.rs:22:16
   |
22 |     temporal::{month_dyn, year_dyn},
   |                ^^^^^^^^^
   |
   = note: `#[warn(deprecated)]` on by default

warning: use of deprecated function `arrow_arith::temporal::year_dyn`: Use `date_part` instead
  --> crates/iceberg/src/transform/temporal.rs:22:27
   |
22 |     temporal::{month_dyn, year_dyn},
   |                           ^^^^^^^^

warning: use of deprecated function `arrow_arith::temporal::year_dyn`: Use `date_part` instead
  --> crates/iceberg/src/transform/temporal.rs:47:13
   |
47 |             year_dyn(&input).map_err(|err| Error::new(ErrorKind::Unexpected, format!("{err}")))?;
   |             ^^^^^^^^

warning: use of deprecated function `arrow_arith::temporal::year_dyn`: Use `date_part` instead
  --> crates/iceberg/src/transform/temporal.rs:65:13
   |
65 |             year_dyn(&input).map_err(|err| Error::new(ErrorKind::Unexpected, format!("{err}")))?;
   |             ^^^^^^^^

warning: use of deprecated function `arrow_arith::temporal::month_dyn`: Use `date_part` instead
  --> crates/iceberg/src/transform/temporal.rs:72:13
   |
72 |             month_dyn(&input).map_err(|err| Error::new(ErrorKind::Unexpected, format!("{err}")))?;
   |             ^^^^^^^^^

error[E0308]: mismatched types
   --> crates/iceberg/src/writer/file_writer/parquet_writer.rs:118:13
    |
116 |         let writer = AsyncArrowWriter::try_new(
    |                      ------------------------- arguments to this function are incorrect
117 |             inner_writer,
118 |             self.schema.clone(),
    |             ^^^^^^^^^^^^^^^^^^^ expected `arrow_schema::schema::Schema`, found `arrow_schema::Schema`
    |
    = note: `arrow_schema::Schema` and `arrow_schema::schema::Schema` have similar names, but are actually distinct types
note: `arrow_schema::Schema` is defined in crate `arrow_schema`
   --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/arrow-schema-51.0.0/src/schema.rs:187:1
    |
187 | pub struct Schema {
    | ^^^^^^^^^^^^^^^^^
note: `arrow_schema::schema::Schema` is defined in crate `arrow_schema`
   --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/arrow-schema-50.0.0/src/schema.rs:181:1
    |
181 | pub struct Schema {
    | ^^^^^^^^^^^^^^^^^
    = note: perhaps two different versions of crate `arrow_schema` are being used?
note: associated function defined here
   --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/parquet-50.0.0/src/arrow/async_writer/mod.rs:95:12
    |
95  |     pub fn try_new(
    |            ^^^^^^^

error[E0308]: mismatched types
   --> crates/iceberg/src/writer/file_writer/parquet_writer.rs:220:27
    |
220 |         self.writer.write(batch).await.map_err(|err| {
    |                     ----- ^^^^^ expected `RecordBatch`, found a different `RecordBatch`
    |                     |
    |                     arguments to this method are incorrect
    |
    = note: `RecordBatch` and `RecordBatch` have similar names, but are actually distinct types
note: `RecordBatch` is defined in crate `arrow_array`
   --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/arrow-array-51.0.0/src/record_batch.rs:72:1
    |
72  | pub struct RecordBatch {
    | ^^^^^^^^^^^^^^^^^^^^^^
note: `RecordBatch` is defined in crate `arrow_array`
   --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/arrow-array-50.0.0/src/record_batch.rs:72:1
    |
72  | pub struct RecordBatch {
    | ^^^^^^^^^^^^^^^^^^^^^^
    = note: perhaps two different versions of crate `arrow_array` are being used?
note: method defined here
   --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/parquet-50.0.0/src/arrow/async_writer/mod.rs:116:18
    |
116 |     pub async fn write(&mut self, batch: &RecordBatch) -> Result<()> {
    |                  ^^^^^

[Fokko]

Thanks for reporting this @viirya. I'm seeing something similar on my local machine:

error[E0308]: mismatched types
   --> /Users/fokkodriesprong/.cargo/git/checkouts/iceberg-rust-d49e83c40ef4cf40/d6703df/crates/iceberg/src/writer/file_writer/parquet_writer.rs:118:13
    |
116 |         let writer = AsyncArrowWriter::try_new(
    |                      ------------------------- arguments to this function are incorrect
117 |             inner_writer,
118 |             self.schema.clone(),
    |             ^^^^^^^^^^^^^^^^^^^ expected `arrow_schema::schema::Schema`, found `arrow_schema::Schema`
    |
    = note: `arrow_schema::Schema` and `arrow_schema::schema::Schema` have similar names, but are actually distinct types
note: `arrow_schema::Schema` is defined in crate `arrow_schema`
   --> /Users/fokkodriesprong/.cargo/registry/src/index.crates.io-6f17d22bba15001f/arrow-schema-51.0.0/src/schema.rs:187:1
    |
187 | pub struct Schema {
    | ^^^^^^^^^^^^^^^^^
note: `arrow_schema::schema::Schema` is defined in crate `arrow_schema`
   --> /Users/fokkodriesprong/.cargo/registry/src/index.crates.io-6f17d22bba15001f/arrow-schema-50.0.0/src/schema.rs:181:1
    |
181 | pub struct Schema {
    | ^^^^^^^^^^^^^^^^^
    = note: perhaps two different versions of crate `arrow_schema` are being used?
note: associated function defined here
   --> /Users/fokkodriesprong/.cargo/registry/src/index.crates.io-6f17d22bba15001f/parquet-50.0.0/src/arrow/async_writer/mod.rs:95:12
    |
95  |     pub fn try_new(
    |            ^^^^^^^

[Xuanwo]

I believe we should commit Cargo.lock to ensure we test against the same version. And we need to establish a MSAV (Minimum Supported Arrow Version) to make sure our users align with our deps.