doc: run doc test#1066
Closed
de-sh wants to merge 2 commits into
Closed
Conversation
Fokko
reviewed
Mar 10, 2025
| @@ -26,23 +26,58 @@ | |||
| //! 2. IcebergWriter: Focus on the logical format of iceberg table. It will write the data using the FileWriter finally. | |||
| //! | |||
| //! # Simple example for data file writer: | |||
Contributor
There was a problem hiding this comment.
Should we put this example under the examples crate? Otherwise it might go out of sync again soon
https://github.com/apache/iceberg-rust/tree/main/crates/examples/src
Contributor
There was a problem hiding this comment.
In #999 we added rust, no_run to the example fragement, so it will compile without running during build
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Are these changes tested?