Add equality_ids to FileScanTaskDeleteFile#1235
Merged
liurenjie1024 merged 2 commits intoApr 23, 2025
Merged
Conversation
Needed to correctly apply equality deletes
Xuanwo
approved these changes
Apr 23, 2025
Xuanwo
left a comment
Xuanwo
left a comment
Member
There was a problem hiding this comment.
Thank you for this change, looks good to me!
liurenjie1024
approved these changes
Apr 23, 2025
liurenjie1024
left a comment
liurenjie1024
left a comment
Contributor
There was a problem hiding this comment.
Thanks @sdd , LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed to correctly apply equality deletes in #982 and #1017