Skip to content

Add support for update_table() function in Sql Catalog#1356

Closed
gsoundar wants to merge 3 commits into
apache:mainfrom
gsoundar:sql-catalog-update-table
Closed

Add support for update_table() function in Sql Catalog#1356
gsoundar wants to merge 3 commits into
apache:mainfrom
gsoundar:sql-catalog-update-table

Conversation

@gsoundar

Copy link
Copy Markdown
  • Takes in a TableCommit object and evaluates requirements with respect to current table metadata.
  • Generates a new metadata file based on updates provided.
  • Writes the new metadata file and atomically tries to commit into the SQL database.
  • Added test for a simple append
  • More tests (needed)
    • Upgrade table version
    • Update sort order
    • Alter schema
    • Update partition spec

Which issue does this PR close?

  • Closes #.

What changes are included in this PR?

Are these changes tested?

- Takes in a TableCommit object and evaluates requirements
  with respect to current table metadata.
- Generates a new metadata file based on updates provided.
- Writes the new metadata file and atomically tries
  to commit into the SQL database.
- Added test for a simple append
- More tests (needed)
  - Upgrade table version
  - Update sort order
  - Alter schema
  - Update partition spec
@ryanwarfield

Copy link
Copy Markdown
Contributor

Does this already exist in #862 ?

@gsoundar

Copy link
Copy Markdown
Author

@kyteware I didn't see the other PR. It doesn't look merged yet. How can I help to review/merge it ?

gsoundar added 2 commits May 20, 2025 09:29
Address CI error for formatting
Address CI error for formatting
Address clippy error
@ryanwarfield

Copy link
Copy Markdown
Contributor

@gsoundar Sorry I didn't see this! I believe this is still the status on update_table implementations. #1002 (review)

@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.

@github-actions github-actions Bot added the stale label Feb 26, 2026
@github-actions

github-actions Bot commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions Bot closed this Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants