Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions crates/storage/opendal/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ use iceberg::io::{
};
use iceberg::{Error, ErrorKind, Result};
use opendal::Operator;
use opendal::layers::RetryLayer;
use opendal::layers::{RetryLayer, TimeoutLayer};
use serde::{Deserialize, Serialize};
use utils::from_opendal_error;

Expand Down Expand Up @@ -326,9 +326,17 @@ impl OpenDalStorage {
}
};

// Transient errors are common for object stores; however there's no
// harm in retrying temporary failures for other storage backends as well.
let operator = operator.layer(RetryLayer::new());
// Apply observability/resilience layers. TimeoutLayer must be
// inside RetryLayer so each retry attempt is independently
// bounded — without a per-attempt timeout, a future parked on a
// silently dropped TCP connection never produces an `Err` and
// RetryLayer cannot retry, leaving the caller hung indefinitely.
// See: https://opendal.apache.org/docs/rust/opendal/layers/struct.TimeoutLayer.html
//
// Transient errors are common for object stores; we retry temporary
// failures with exponential backoff. The retry behavior also
// benefits non-object-store backends.
let operator = operator.layer(TimeoutLayer::new()).layer(RetryLayer::new());
Ok((operator, relative_path))
}

Expand Down
Loading