refactor(spec): make TableProperties own the raw HashMap

crates/catalog/glue/src/catalog.rs

@@ -607,7 +607,7 @@ impl Catalog for GlueCatalog {
             &table_name,
             metadata_location_str.clone(),
             &metadata,
-            metadata.properties(),
+            metadata.properties().as_raw(),
             None,
         )?;
 
@@ -825,7 +825,7 @@ impl Catalog for GlueCatalog {
             table_name,
             metadata_location.clone(),
             &metadata,
-            metadata.properties(),
+            metadata.properties().as_raw(),
             None,
         )?;
 
@@ -894,7 +894,7 @@ impl Catalog for GlueCatalog {
                 table_ident.name(),
                 staged_metadata_location.to_string(),
                 staged_table.metadata(),
-                staged_table.metadata().properties(),
+                staged_table.metadata().properties().as_raw(),
                 Some(current_metadata_location),
             )?);
 

crates/catalog/glue/src/utils.rs

@@ -340,7 +340,7 @@ mod tests {
             &table_name,
             metadata_location,
             &metadata,
-            metadata.properties(),
+            metadata.properties().as_raw(),
             None,
         )?;
 

crates/catalog/hms/src/catalog.rs

@@ -530,7 +530,7 @@ impl Catalog for HmsCatalog {
             table_name.clone(),
             location,
             metadata_location_str.clone(),
-            metadata.properties(),
+            metadata.properties().as_raw(),
         )?;
 
         self.client

crates/catalog/rest/src/catalog.rs

@@ -2302,7 +2302,7 @@ mod tests {
                     "gzip".to_string()
                 )
             ]),
-            table.metadata().properties()
+            table.metadata().properties().as_raw()
         );
         assert_eq!(vec![&Arc::new(Snapshot::builder()
             .with_snapshot_id(3497810964824022504)
@@ -2517,7 +2517,7 @@ mod tests {
                     "zstd".to_string()
                 ),
             ]),
-            table.metadata().properties()
+            table.metadata().properties().as_raw()
         );
         assert!(table.metadata().current_snapshot().is_none());
         assert!(table.metadata().history().is_empty());
@@ -2718,7 +2718,7 @@ mod tests {
                     "zstd".to_string()
                 ),
             ]),
-            table.metadata().properties()
+            table.metadata().properties().as_raw()
         );
         assert!(table.metadata().current_snapshot().is_none());
         assert!(table.metadata().history().is_empty());

crates/catalog/sql/src/catalog.rs

@@ -1165,7 +1165,7 @@ mod tests {
             vec![&expected_sorted_order]
         );
 
-        assert_eq!(metadata.properties(), &HashMap::new());
+        assert_eq!(metadata.properties().as_raw(), &HashMap::new());
 
         assert!(!table.readonly());
     }

crates/iceberg/src/catalog/memory/catalog.rs

@@ -541,7 +541,7 @@ pub(crate) mod tests {
             vec![&expected_sorted_order]
         );
 
-        assert_eq!(metadata.properties(), &HashMap::new());
+        assert_eq!(metadata.properties().as_raw(), &HashMap::new());
 
         assert!(!table.readonly());
     }

crates/iceberg/src/catalog/metadata_location.rs

@@ -15,14 +15,13 @@
 // specific language governing permissions and limitations
 // under the License.
 
-use std::collections::HashMap;
 use std::fmt::Display;
 use std::str::FromStr;
 
 use uuid::Uuid;
 
 use crate::compression::CompressionCodec;
-use crate::spec::{TableMetadata, parse_metadata_file_compression};
+use crate::spec::{TableMetadata, TableProperties};
 use crate::{Error, ErrorKind, Result};
 
 /// Helper for parsing a location of the format: `<location>/metadata/<version>-<uuid>.metadata.json`
@@ -38,8 +37,8 @@ pub struct MetadataLocation {
 impl MetadataLocation {
     /// Determines the compression codec from table properties.
     /// Parse errors result in CompressionCodec::None.
-    fn compression_from_properties(properties: &HashMap<String, String>) -> CompressionCodec {
-        parse_metadata_file_compression(properties).unwrap_or(CompressionCodec::None)
+    fn compression_from_properties(properties: &TableProperties) -> CompressionCodec {
+        properties.metadata_compression_codec
     }
 
     /// Creates a completely new metadata location starting at version 0.

crates/iceberg/src/catalog/utils.rs

@@ -62,7 +62,7 @@ pub async fn drop_table_data(
     }
 
     // Delete data files only if gc.enabled is true, to avoid corrupting shared tables
-    if metadata.table_properties()?.gc_enabled {
+    if metadata.properties().gc_enabled {
         delete_data_files(io, &manifests_to_delete).await?;
     }
 

crates/iceberg/src/spec/mod.rs

@@ -50,7 +50,6 @@ pub use sort::*;
 pub use statistic_file::*;
 pub use table_metadata::*;
 pub(crate) use table_metadata_builder::FIRST_FIELD_ID;
-pub(crate) use table_properties::parse_metadata_file_compression;
 pub use table_properties::*;
 pub use transform::*;
 pub(crate) use values::decimal_utils;