Skip to content

Use cargo publish to publish crates#2489

Merged
kevinjqliu merged 3 commits into
apache:mainfrom
blackmwk:ir-2488
May 25, 2026
Merged

Use cargo publish to publish crates#2489
kevinjqliu merged 3 commits into
apache:mainfrom
blackmwk:ir-2488

Conversation

@blackmwk
Copy link
Copy Markdown
Contributor

Which issue does this PR close?

What changes are included in this PR?

Inspired by #2485 , we add missing crates in publish workflow. But instead of maintaining crates publishing order manually, we switch to use cargo publish --workspace to publish crates.

Are these changes tested?

Ran cargo publish --workspace --all-features --dry-run --no-verify --allow-dirty locally.

@blackmwk blackmwk requested review from CTTY, Xuanwo and kevinjqliu May 23, 2026 02:07
Copy link
Copy Markdown
Contributor

@kevinjqliu kevinjqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Looks like we're adding 2 new crates iceberg-cache-moka and iceberg-catalog-loader.
I see you've added catagory/description/keyword to iceberg-cache-moka.
Is the iceberg-catalog-loader change intentional?

Crate Path In old matrix?
iceberg crates/iceberg/Cargo.toml yes
iceberg-storage-opendal crates/storage/opendal/Cargo.toml yes
iceberg-catalog-glue crates/catalog/glue/Cargo.toml yes
iceberg-catalog-hms crates/catalog/hms/Cargo.toml yes
iceberg-catalog-rest crates/catalog/rest/Cargo.toml yes
iceberg-catalog-s3tables crates/catalog/s3tables/Cargo.toml yes
iceberg-catalog-sql crates/catalog/sql/Cargo.toml yes
iceberg-datafusion crates/integrations/datafusion/Cargo.toml yes
iceberg-cache-moka crates/integrations/cache-moka/Cargo.toml new
iceberg-catalog-loader crates/catalog/loader/Cargo.toml new

Nit: Also might be better to add

[workspace.package]
publish = false

to the workspace Cargo.toml so all crates are not published by default. This can prevent a new crate from being published accidentally (with the current approach, someone has to remember to set publish = false)

@blackmwk
Copy link
Copy Markdown
Contributor Author

LGTM

Looks like we're adding 2 new crates iceberg-cache-moka and iceberg-catalog-loader. I see you've added catagory/description/keyword to iceberg-cache-moka. Is the iceberg-catalog-loader change intentional?

Crate Path In old matrix?
iceberg crates/iceberg/Cargo.toml yes
iceberg-storage-opendal crates/storage/opendal/Cargo.toml yes
iceberg-catalog-glue crates/catalog/glue/Cargo.toml yes
iceberg-catalog-hms crates/catalog/hms/Cargo.toml yes
iceberg-catalog-rest crates/catalog/rest/Cargo.toml yes
iceberg-catalog-s3tables crates/catalog/s3tables/Cargo.toml yes
iceberg-catalog-sql crates/catalog/sql/Cargo.toml yes
iceberg-datafusion crates/integrations/datafusion/Cargo.toml yes
iceberg-cache-moka crates/integrations/cache-moka/Cargo.toml new
iceberg-catalog-loader crates/catalog/loader/Cargo.toml new
Nit: Also might be better to add

[workspace.package]
publish = false

to the workspace Cargo.toml so all crates are not published by default. This can prevent a new crate from being published accidentally (with the current approach, someone has to remember to set publish = false)

Done, fixed.

Copy link
Copy Markdown
Contributor

@kevinjqliu kevinjqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM i see 10 sets of publish = true, matching the table above

@kevinjqliu kevinjqliu merged commit a3d2764 into apache:main May 25, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use cargo workspace publish to publishing crates.

2 participants