Build: disable link-check for existing medium blog posts#10042
Conversation
|
While it's great to have retries, it seems that this doesn't solve the issue and the Link checker runs for 48m+. So maybe we should just do |
Is the order of checking the links deterministic? If it is, then that can hide issues (page is not actually present, but by the time you get there it is a 429 --- what are the chances/do we care?). If the order of traversal is not deterministic, then we can perhaps ignore throttling (as you would expect to catch the dead links at some point anyway). |
manuzhang
changed the title
| ], | ||
| "retryOn429": true, | ||
| "retryCount": 5, | ||
| "fallbackRetryDelay": "120s" |
There was a problem hiding this comment.
can we reduce the retries? I think with that retry the last CI run took 48 mins, which is too long IMO
There was a problem hiding this comment.
I don't think it will work anyway. I'm not exploring this approach now.
|
I'm just disabling link check for existing medium blog posts, which have been causing failure due to 429. WDYT? |
Yeah I think this is probably the best for now. Can you remove the retry config and we'll go with the current approach? |
Done. |
|
@manuzhang it looks like there are a few more medium links that haven't been covered. Can you please follow-up on those as well? |
|
@nastra Sure, do we want to run link check on main branch or just PRs for changed docs? |
|
@manuzhang can you open up a PR to fix the remaining links please? Also IMO we should be running this for PRs and on main |
3 participants
This fixes #10038