Introduce two properties for reading the connection timeout and socke…#10053
Merged
nastra merged 5 commits intoApr 11, 2024
Merged
Conversation
…t timeout (#10) * Introduce two properties for reading the connection timeout and socket timeout values * Rulin and Maninder comments * Refactor and add test * Refactor to make constructor cleaner * Minor fixes * Test socket timeout behavior
nastra
reviewed
Mar 28, 2024
nastra
reviewed
Apr 2, 2024
nastra
reviewed
Apr 2, 2024
nastra
reviewed
Apr 2, 2024
nastra
reviewed
Apr 2, 2024
nastra
reviewed
Apr 2, 2024
nastra
reviewed
Apr 2, 2024
nastra
reviewed
Apr 2, 2024
nastra
reviewed
Apr 2, 2024
nastra
reviewed
Apr 2, 2024
nastra
reviewed
Apr 8, 2024
nastra
reviewed
Apr 8, 2024
nastra
reviewed
Apr 8, 2024
nastra
approved these changes
Apr 11, 2024
Contributor
nastra
left a comment
nastra
left a comment
There was a problem hiding this comment.
LGTM, thanks @harishch1998
sasankpagolu
pushed a commit
to sasankpagolu/iceberg
that referenced
this pull request
Oct 27, 2024
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
fbertsch
pushed a commit
to fbertsch/iceberg
that referenced
this pull request
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes code changes to make the REST HTTPClient's socket and connection timeout values configurable. Introducing two new properties to help achieve this.