Docs: Document support for binary in truncate transform#10079
Merged
Conversation
github-actions
Bot
added
the
Specification
TheNeuralBit
force-pushed
the
truncate-binary-doc
branch
from
03ce155 to
bc22194
Compare
TheNeuralBit
commented
Apr 4, 2024
Member
Author
TheNeuralBit
left a comment
TheNeuralBit
left a comment
There was a problem hiding this comment.
Thanks for the feedback :)
Fokko
approved these changes
Apr 4, 2024
Contributor
There was a problem hiding this comment.
Looks good. Thanks for adding this @TheNeuralBit. We already do this for PyIceberg as well: https://github.com/apache/iceberg-python/blob/ee4dd92008ffa21067837fe9fcdfaea063a514f3/pyiceberg/transforms.py#L633-L635
rdblue
approved these changes
Apr 8, 2024
amogh-jahagirdar
approved these changes
Apr 8, 2024
Contributor
|
Merged. Thanks for addressing this @TheNeuralBit! thanks for the reviews @Fokko @rdblue |
sasankpagolu
pushed a commit
to sasankpagolu/iceberg
that referenced
this pull request
Oct 27, 2024
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5251
It seems unlikely we will address this discrepancy by dropping support for binary. I'd like to propose documenting the currently implemented behavior instead.