Build: Ignore link-checking for Blogs / https://search.maven.org/#10081
Merged
Conversation
Fokko
approved these changes
Apr 3, 2024
manuzhang
reviewed
Apr 3, 2024
|
|
||
| **Author**: [Alex Merced](https://www.linkedin.com/in/alexmerced/) | ||
|
|
||
| <!-- markdown-link-check-disable-next-line --> |
Member
There was a problem hiding this comment.
Actually we only need to put <!-- markdown-link-check-disable --> and <!-- markdown-link-check-enable--> at the beginning and the end if we want to disable checking the whole doc.
Contributor
Author
There was a problem hiding this comment.
good point, I should have done that but didn't realize such a setting is available
Member
There was a problem hiding this comment.
I was thinking about a workflow. When new blogs are added in a PR, they can be placed before <!-- markdown-link-check-disable --> to check link. When the link check passes, we place <!-- markdown-link-check-disable --> at the beginning again before merging the PR. That's a bit complex, though.
sasankpagolu
pushed a commit
to sasankpagolu/iceberg
that referenced
this pull request
Oct 27, 2024
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #10060