Spec: required request bodies#10125
Merged
amogh-jahagirdar merged 1 commit intoApr 12, 2024
Merged
Conversation
nastra
reviewed
Apr 12, 2024
| The server might also add properties, such as `last_modified_time` etc. | ||
| operationId: createNamespace | ||
| requestBody: | ||
| required: true |
Contributor
There was a problem hiding this comment.
can you also please add the same for getToken?
westse
force-pushed
the
openapi-required-request-body
branch
from
80f9b26 to
4bf574e
Compare
nastra
approved these changes
Apr 12, 2024
amogh-jahagirdar
approved these changes
Apr 12, 2024
Contributor
amogh-jahagirdar
left a comment
amogh-jahagirdar
left a comment
There was a problem hiding this comment.
Good find @westse ! the bodies should be required. I diffed the cases where already specified required: true, and what we were missing and this covers the remainder!
Contributor
sasankpagolu
pushed a commit
to sasankpagolu/iceberg
that referenced
this pull request
Oct 27, 2024
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10004