SHOW VIEWS failed with AssertionError

[huaxingao]

sql("CREATE VIEW %s AS SELECT 1 AS id", "test");
sql("SHOW VIEWS")

assertion failed
java.lang.AssertionError: assertion failed
	at scala.Predef$.assert(Predef.scala:208)
	at org.apache.spark.sql.connector.catalog.LookupCatalog$CatalogAndNamespace$.unapply(LookupCatalog.scala:84)
	at org.apache.spark.sql.catalyst.analysis.RewriteViewCommands$$anonfun$apply$1.applyOrElse(RewriteViewCommands.scala:74)
	at org.apache.spark.sql.catalyst.analysis.RewriteViewCommands$$anonfun$apply$1.applyOrElse(RewriteViewCommands.scala:51)

[huaxingao]

cc @nastra @szehon-ho @flyrain

[szehon-ho]

@nastra fyi

[szehon-ho]

Ill commit this tomorrow if no further comments

[nastra]

I'll take a look later today

[nastra]

expected can be inlined here:

Suggested change

	assertThat(sql("SHOW VIEWS")).contains(expected);
	assertThat(sql("SHOW VIEWS")).contains(row("default", "test", false));

[huaxingao]

Fixed. Thanks for the suggestion!

[nastra]

Suggested change

	assertThat(sql("SHOW VIEWS")).contains(expected);
	assertThat(sql("SHOW VIEWS")).contains(row("default", "test", false));

[nastra]

LGTM with one suggestion, thanks for catching this

[nastra]

@huaxingao could you also please add the below diff to TestViews.showViews()

--- a/spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java
+++ b/spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java
@@ -1462,6 +1462,11 @@ public class TestViews extends ExtensionsTestBase {
         .contains(
             // spark stores temp views case-insensitive by default
             row("global_temp", "globalviewforlisting", true), tempView);
+
+    sql("USE spark_catalog");
+    assertThat(sql("SHOW VIEWS")).contains(tempView);
+
+    assertThat(sql("SHOW VIEWS IN default")).contains(tempView);
   }

[huaxingao]

could you also please add the below diff to TestViews.showViews()

Added. Thanks for the suggestion! @nastra

[szehon-ho]

Thanks @huaxingao for the pr, @nastra @viirya for reviews

[huaxingao]

Thanks, everyone!