Skip to content

Build: Clean up Jackson dependency usages#10448

Merged
amogh-jahagirdar merged 1 commit into
apache:mainfrom
nastra:clean-up-jackson-deps
Jun 5, 2024
Merged

Build: Clean up Jackson dependency usages#10448
amogh-jahagirdar merged 1 commit into
apache:mainfrom
nastra:clean-up-jackson-deps

Conversation

@nastra
Copy link
Copy Markdown
Contributor

@nastra nastra commented Jun 5, 2024

No description provided.

@nastra nastra force-pushed the clean-up-jackson-deps branch from fda10f1 to 25d7e00 Compare June 5, 2024 12:15
Comment thread gradle/libs.versions.toml
jackson-bom = { module = "com.fasterxml.jackson:jackson-bom", version.ref = "jackson-bom" }
jackson-core = { module = "com.fasterxml.jackson:jackson-core", version.ref = "jackson-bom" }
jackson-databind = { module = "com.fasterxml.jackson:jackson-databind", version.ref = "jackson-bom" }
jackson-core = { module = "com.fasterxml.jackson.core:jackson-core", version.ref = "jackson-bom" }
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the module definitions were wrong here

@nastra nastra requested a review from amogh-jahagirdar June 5, 2024 12:23
Copy link
Copy Markdown
Contributor

@amogh-jahagirdar amogh-jahagirdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nastra !

@amogh-jahagirdar amogh-jahagirdar merged commit a642a93 into apache:main Jun 5, 2024
@nastra nastra deleted the clean-up-jackson-deps branch June 5, 2024 15:28
jasonf20 pushed a commit to jasonf20/iceberg that referenced this pull request Aug 4, 2024
sasankpagolu pushed a commit to sasankpagolu/iceberg that referenced this pull request Oct 27, 2024
zachdisc pushed a commit to zachdisc/iceberg that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants