Skip to content

Remove redundant -XX:+IgnoreUnrecognizedVMOptions#10475

Merged
Fokko merged 1 commit into
apache:mainfrom
findepi:findepi/remove-redundant-xx-ignoreunrecognizedvmoptions-ef22dc
Jun 17, 2024
Merged

Remove redundant -XX:+IgnoreUnrecognizedVMOptions#10475
Fokko merged 1 commit into
apache:mainfrom
findepi:findepi/remove-redundant-xx-ignoreunrecognizedvmoptions-ef22dc

Conversation

@findepi
Copy link
Copy Markdown
Member

@findepi findepi commented Jun 10, 2024

The JVM flags are set depending on Java version. We should not be setting any flags that are not expected to be supported.

The JVM flags are set depending on Java version.  We should not be
setting any flags that are not expected to be supported.
@github-actions github-actions Bot added the build label Jun 10, 2024
@findepi findepi requested a review from Fokko June 10, 2024 09:49
@Fokko
Copy link
Copy Markdown
Contributor

Fokko commented Jun 11, 2024

@singhpk234 Any specific reason for adding the -XX:+IgnoreUnrecognizedVMOptions flag?

@findepi
Copy link
Copy Markdown
Member Author

findepi commented Jun 17, 2024

the flag seems to have been added in 8dd29ca

Copy link
Copy Markdown
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @findepi for the PR, and @jbonofre for the review 👍

@Fokko Fokko merged commit ae6f906 into apache:main Jun 17, 2024
@findepi findepi deleted the findepi/remove-redundant-xx-ignoreunrecognizedvmoptions-ef22dc branch June 17, 2024 19:25
@findepi
Copy link
Copy Markdown
Member Author

findepi commented Jun 17, 2024

thanks @Fokko for the merge!

jasonf20 pushed a commit to jasonf20/iceberg that referenced this pull request Aug 4, 2024
The JVM flags are set depending on Java version.  We should not be
setting any flags that are not expected to be supported.
sasankpagolu pushed a commit to sasankpagolu/iceberg that referenced this pull request Oct 27, 2024
The JVM flags are set depending on Java version.  We should not be
setting any flags that are not expected to be supported.
zachdisc pushed a commit to zachdisc/iceberg that referenced this pull request Dec 23, 2024
The JVM flags are set depending on Java version.  We should not be
setting any flags that are not expected to be supported.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants