Mr: Optimize schema string retrieval in Iceberg#10489
Merged
Merged
Conversation
Fokko
approved these changes
Jun 14, 2024
amogh-jahagirdar
approved these changes
Jun 14, 2024
jasonf20
pushed a commit
to jasonf20/iceberg
that referenced
this pull request
Aug 4, 2024
Co-authored-by: howieyang <howieyang@tencent.com>
sasankpagolu
pushed a commit
to sasankpagolu/iceberg
that referenced
this pull request
Oct 27, 2024
Co-authored-by: howieyang <howieyang@tencent.com>
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
Co-authored-by: howieyang <howieyang@tencent.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR optimizes the retrieval of the schema string in Iceberg. Instead of calling
props.getProperty(InputFormatConfig.TABLE_SCHEMA)twice, the method is now called once and the result is stored in the schemaString variable. This variable is then used for parsing the schema, reducing unnecessary method calls and improving code efficiency.