Skip to content

Rename allVersions to allModules#10499

Merged
nastra merged 1 commit into
apache:mainfrom
findepi:findepi/main/rename-allversions-to-allmodules-88b93f
Jun 15, 2024
Merged

Rename allVersions to allModules#10499
nastra merged 1 commit into
apache:mainfrom
findepi:findepi/main/rename-allversions-to-allmodules-88b93f

Conversation

@findepi
Copy link
Copy Markdown
Member

@findepi findepi commented Jun 15, 2024

The meaning of the flag is to enable all modules. In particular, it does not enable all Scala versions for the build. The new name more directly conveys the intent.

The meaning of the flag is to enable all modules. In particular, it does
not enable all Scala versions for the build. The new name more directly
conveys the intent.
@findepi
Copy link
Copy Markdown
Member Author

findepi commented Jun 15, 2024

cc @pan3793

@nastra nastra merged commit b7a0bea into apache:main Jun 15, 2024
@findepi findepi deleted the findepi/main/rename-allversions-to-allmodules-88b93f branch June 15, 2024 12:54
@findepi
Copy link
Copy Markdown
Member Author

findepi commented Jun 15, 2024

thanks for the merge, @nastra !

jasonf20 pushed a commit to jasonf20/iceberg that referenced this pull request Aug 4, 2024
The meaning of the flag is to enable all modules. In particular, it does
not enable all Scala versions for the build. The new name more directly
conveys the intent.
sasankpagolu pushed a commit to sasankpagolu/iceberg that referenced this pull request Oct 27, 2024
The meaning of the flag is to enable all modules. In particular, it does
not enable all Scala versions for the build. The new name more directly
conveys the intent.
zachdisc pushed a commit to zachdisc/iceberg that referenced this pull request Dec 23, 2024
The meaning of the flag is to enable all modules. In particular, it does
not enable all Scala versions for the build. The new name more directly
conveys the intent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants