Require Assertions to be statically imported #10517
Merged
Merged
Conversation
Member
Author
Member
Author
Contributor
|
This might take a few days to review as I just made it through the first 100 files |
Member
Author
|
no worries, thanks for reviewing! |
Member
Author
|
rebased & updated for #10500 |
Member
Author
|
@nastra if this helps, i can split this PR into smaller ones, eg by module. |
Contributor
|
@findepi yeah I think it would make sense to split out the Flink + Spark changes. Everything else can stay in this PR |
This was referenced Jun 18, 2024
Member
Author
Contributor
|
This can be rebased now, since the other 2 PRs have been merged |
Per code style recommendations.
Member
Author
|
rebased |
nastra
approved these changes
Jun 18, 2024
Contributor
nastra
left a comment
nastra
left a comment
There was a problem hiding this comment.
LGTM, thanks for cleaning this up
Member
Author
|
thanks for your review @nastra ! |
jasonf20
pushed a commit
to jasonf20/iceberg
that referenced
this pull request
Aug 4, 2024
sasankpagolu
pushed a commit
to sasankpagolu/iceberg
that referenced
this pull request
Oct 27, 2024
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #10500 (comment)