AWS: Don't complete multipart upload on finalize for S3OutputStream#10874
Merged
Conversation
If a user didn't call close on the stream the file shouldn't be uploaded. This means that if the user forgets to call close() on a completed file it will no longer be uploaded. However, this is preferred to having files which were intentionally not closed being uploaded.
jasonf20
force-pushed
the
dont-upload-partial-files
branch
from
aecc55f to
1a5b6ee
Compare
amogh-jahagirdar
changed the title
amogh-jahagirdar
approved these changes
Aug 6, 2024
Contributor
There was a problem hiding this comment.
I generally support this change. We should not finish upload on GC's because anything that should be written out as part of the table must have been explicitly closed. It also saves machines from doing extra work during the garbage collection (theoretically reducing pause times)
I also don't think we should be relying on GC finishing uploads so I'm not really concerned about that side effect change.
Would be great to get @danielcweeks @jackye1995 opinion as well in case they see any issues.
Contributor
Author
|
HI @danielcweeks @jackye1995 would appreciate it if you can take a look. |
Contributor
Author
|
@amogh-jahagirdar any way to move this forward? |
Fokko
approved these changes
Aug 20, 2024
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
This makes sense to me as well
amogh-jahagirdar
changed the title
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a user didn't call close on the stream the file shouldn't be uploaded.
This means that if the user forgets to call
close()on a completed file it will no longer be uploaded. However, this is preferred to having files which were intentionally not closed being uploaded and creating garbage.