Spark 3.5: Fix incorrect catalog loaded in TestCreateActions#10952
Merged
Conversation
manuzhang
force-pushed
the
test-create-actions
branch
from
5ba0ed9 to
fdf18aa
Compare
manuzhang
changed the title
manuzhang
force-pushed
the
test-create-actions
branch
from
445f9b6 to
d9c3bc6
Compare
manuzhang
changed the title
nastra
reviewed
Aug 19, 2024
manuzhang
force-pushed
the
test-create-actions
branch
from
d9c3bc6 to
ac6973e
Compare
nastra
approved these changes
Aug 22, 2024
Contributor
nastra
left a comment
nastra
left a comment
There was a problem hiding this comment.
overall LGTM, but I would probably reference spark_catalog directly, since that's the catalog that seems to cause issues
manuzhang
force-pushed
the
test-create-actions
branch
from
ac6973e to
3b9808c
Compare
nastra
reviewed
Aug 22, 2024
| this.catalog = (TableCatalog) spark.sessionState().catalogManager().catalog(catalogName); | ||
|
|
||
| if (!catalogName.equals("spark_catalog")) { | ||
| spark.conf().set("spark.sql.catalog.spark_catalog", SparkSessionCatalog.class.getName()); |
Contributor
There was a problem hiding this comment.
I don't think this ever needs to be set?
Member
Author
There was a problem hiding this comment.
This is needed to migrate from a non-Iceberg catalog table since we unset spark.sql.catalog.spark_catalog now.
Contributor
There was a problem hiding this comment.
sorry, this is probably my bad due to my earlier suggestion. I think we can remove setting this here if we remove spark.conf().unset("spark.sql.catalog.spark_catalog");. That way all tests should still pass
nastra
reviewed
Aug 22, 2024
nastra
reviewed
Aug 22, 2024
Contributor
|
thanks for fixing this @manuzhang |
manuzhang
added a commit
to manuzhang/iceberg
that referenced
this pull request
Aug 30, 2024
manuzhang
added a commit
to manuzhang/iceberg
that referenced
this pull request
Sep 1, 2024
manuzhang
added a commit
to manuzhang/iceberg
that referenced
this pull request
Sep 2, 2024
nastra
pushed a commit
that referenced
this pull request
Sep 9, 2024
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this fix,
HiveCatalogis loaded instead ofHadoopCatalogdue to spark sql config is not cleared up after each test inTestCreateActions.After the correct catalog is loaded, more migrate tests need to be skipped for
HadoopCatalog.cc @chinmay-bhat @nastra