Flink: FLIP-27 IcebergSource builder missed a couple of configs compared to old FlinkSource: expose locality and plan parallelism#10957
Merged
Conversation
stevenzwu
force-pushed
the
flink-source-sync-builder
branch
from
11bae98 to
e3828e0
Compare
…red to old FlinkSource: expose locality and plan parallelism
stevenzwu
force-pushed
the
flink-source-sync-builder
branch
from
e3828e0 to
fa2eaa0
Compare
pvary
approved these changes
Aug 19, 2024
liuml07
reviewed
Nov 2, 2024
| contextBuilder.resolveConfig(table, readOptions, flinkConfig); | ||
| contextBuilder.exposeLocality( | ||
| SourceUtil.isLocalityEnabled(table, flinkConfig, exposeLocality)); | ||
| contextBuilder.planParallelism( |
Member
There was a problem hiding this comment.
Quick question: I see contextBuilder.resolveConfig(table, readOptions, flinkConfig) above already sets the planParallelism via .planParallelism(flinkReadConf.workerPoolSize()), is that not sufficient?
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
…red to old FlinkSource: expose locality and plan parallelism (apache#10957)
czy006
pushed a commit
to czy006/iceberg
that referenced
this pull request
Apr 2, 2025
…red to old FlinkSource: expose locality and plan parallelism (apache#10957) (cherry picked from commit 43bbf08)
czy006
pushed a commit
to czy006/iceberg
that referenced
this pull request
Apr 2, 2025
…red to old FlinkSource: expose locality and plan parallelism (apache#10957) (cherry picked from commit 43bbf08)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.