Flink: Maintenance - Lock remover#11010
Merged
Merged
Conversation
stevenzwu
reviewed
Aug 26, 2024
stevenzwu
reviewed
Aug 27, 2024
stevenzwu
reviewed
Aug 27, 2024
advancedxy
reviewed
Aug 29, 2024
| duration, | ||
| taskResult.success(), | ||
| taskResult.exceptions()))); | ||
| lock.unlock(); |
Contributor
There was a problem hiding this comment.
I don't quite follow the logic.
the lock is always unlocked in both processElement and processWatermark, when will this lock will be locked, in the TriggerManager?
Contributor
Author
There was a problem hiding this comment.
You can check the Locking paragraph in the design doc: https://docs.google.com/document/d/16g3vR18mVBy8jbFaLjf2JwAANuYOmIwr15yDDxovdnA
If you still have questions, feel free to ask
Contributor
Author
|
@stevenzwu: I didn't get answer for my question on the Flink dev list about the output of the PostCommitTopology. See: https://lists.apache.org/thread/28qb1q6b7kz30dqjdbsw855osx4t38s7 I created some unit test and checked that if we return After some back-and-forth myself, I decided to move forward with the
The Please share your thoughts, and review. |
stevenzwu
approved these changes
Sep 11, 2024
Contributor
Author
|
Merged to main. |
pvary
pushed a commit
to pvary/iceberg
that referenced
this pull request
Sep 12, 2024
pvary
added a commit
that referenced
this pull request
Sep 12, 2024
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
czy006
pushed a commit
to czy006/iceberg
that referenced
this pull request
Apr 2, 2025
(cherry picked from commit 6ff7a6e)
czy006
pushed a commit
to czy006/iceberg
that referenced
this pull request
Apr 2, 2025
(cherry picked from commit ab0594b)
czy006
added a commit
to czy006/iceberg
that referenced
this pull request
Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Operator to remove the lock at the end of the Maintenance flow.
https://docs.google.com/document/d/16g3vR18mVBy8jbFaLjf2JwAANuYOmIwr15yDDxovdnA/edit#heading=h.lt9eaimi6zyz