Flink: Maintenance - TableManager + ExpireSnapshots#11144
Merged
Conversation
Contributor
Author
|
@stevenzwu: This PR become quite sizeable. I still think that it is better to keep it as one to provide context for some of the decisions made during the definition of the If you have time we could discuss offline the review strategy, and whether to split this PR to smaller ones. Thanks, |
pvary
force-pushed
the
flow
branch
3 times, most recently
from
a1dabe5 to
96322c5
Compare
stevenzwu
reviewed
Sep 16, 2024
stevenzwu
reviewed
Sep 17, 2024
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.iceberg.flink.maintenance.stream; |
Contributor
There was a problem hiding this comment.
I don't know if users would interpret stream sub package as pubic APIs. It is better to use proper Java class scope for that purpose. public classes are public and non-public classes can be package private.
stevenzwu
reviewed
Sep 17, 2024
stevenzwu
reviewed
Sep 18, 2024
pvary
force-pushed
the
flow
branch
5 times, most recently
from
fa56618 to
2403f44
Compare
stevenzwu
reviewed
Sep 25, 2024
stevenzwu
reviewed
Sep 26, 2024
stevenzwu
reviewed
Sep 26, 2024
Contributor
Author
|
@netvl: I'm struggling to find the relevant comment (there are too many of them already), but I would like to ask you to check if the proposed Thanks, |
Contributor
Author
|
@rodmeneses: If you have time, I would like to ask you to review the PR. |
rodmeneses
reviewed
Sep 26, 2024
rodmeneses
reviewed
Sep 26, 2024
rodmeneses
reviewed
Sep 26, 2024
rodmeneses
reviewed
Sep 26, 2024
rodmeneses
reviewed
Sep 26, 2024
This was referenced Oct 1, 2024
stevenzwu
reviewed
Oct 23, 2024
stevenzwu
approved these changes
Oct 24, 2024
| TableLoader newTableLoader, | ||
| String defaultUidSuffix, | ||
| String defaultSlotSharingGroup, | ||
| int mainParallelism) { |
Contributor
There was a problem hiding this comment.
this should also be defaultParallelism?
Contributor
Author
|
Merged to main. |
pvary
pushed a commit
to pvary/iceberg
that referenced
this pull request
Nov 5, 2024
pvary
added a commit
that referenced
this pull request
Nov 8, 2024
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
3 tasks
rodmeneses
pushed a commit
to rodmeneses/iceberg
that referenced
this pull request
Jun 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TableManager builder implementation along with the first maintenance task to provide context.
https://docs.google.com/document/d/16g3vR18mVBy8jbFaLjf2JwAANuYOmIwr15yDDxovdnA/edit#heading=h.yd2vbtnf7z6w